Allow ChildReconciler to manage resource in other namespaces #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When listing candidate children, by default we limit the listing to resources in the same namespace as the parent for efficiency. Now a ChildReconciler may use the ListOptions method to return a custom set of []ListOption. This may use any list options available within controller runtime, including indexed fields. When used in conjunction with finalizers and WithConfig we should be able to manage child resources in other clusters (needs verification). Signed-off-by: Scott Andrews <andrewssc@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #236 +/- ##
==========================================
+ Coverage 65.83% 66.34% +0.50%
==========================================
Files 9 9
Lines 1127 1144 +17
==========================================
+ Hits 742 759 +17
Misses 360 360
Partials 25 25
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When listing candidate children, by default we limit the listing to
resources in the same namespace as the parent for efficiency. Now a
ChildReconciler may use the ListOptions method to return a custom set of
[]ListOption. This may use any list options available within controller
runtime, including indexed fields.
When used in conjunction with finalizers and WithConfig we should be
able to manage child resources in other clusters (needs verification).
Signed-off-by: Scott Andrews andrewssc@vmware.com