Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow WithConfig to create dynamic configs #220

Merged
merged 1 commit into from May 5, 2022

Conversation

scothis
Copy link
Contributor

@scothis scothis commented May 3, 2022

WithConfig#Config is now a function that has access to the context and
the current config. A custom config can be created for a specific parent
resource.

This would be a breaking change to WithConfig, except that it has not been released yet.

Signed-off-by: Scott Andrews andrewssc@vmware.com

WithConfig#Config is now a function that has access to the context and
the current config. A custom config can be created for a specific parent
resource.

Signed-off-by: Scott Andrews <andrewssc@vmware.com>
@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #220 (456dff3) into main (2ac8d0c) will decrease coverage by 0.29%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #220      +/-   ##
==========================================
- Coverage   62.14%   61.84%   -0.30%     
==========================================
  Files           9        9              
  Lines         906      912       +6     
==========================================
+ Hits          563      564       +1     
- Misses        325      329       +4     
- Partials       18       19       +1     
Impacted Files Coverage Δ
reconcilers/reconcilers.go 79.34% <33.33%> (-0.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ac8d0c...456dff3. Read the comment docs.

@scothis scothis merged commit 09aa7e9 into vmware-labs:main May 5, 2022
@scothis scothis deleted the dynamic-config branch May 5, 2022 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants