Add parent resource as a given #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a real controller the parent reconciler loads the parent resource from the api server. When testing a sub reconciler, we can assume the parent resource as a given resource. Users who want to test when the parent resource is deleted from the api server after the reconciliation starts can use a reactor to inject a not found error. Signed-off-by: Scott Andrews <andrewssc@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #206 +/- ##
=======================================
Coverage 64.71% 64.71%
=======================================
Files 8 8
Lines 768 768
=======================================
Hits 497 497
Misses 256 256
Partials 15 15 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a real controller the parent reconciler loads the parent resource
from the api server. When testing a sub reconciler, we can assume the
parent resource as a given resource.
Users who want to test when the parent resource is deleted from the api
server after the reconciliation starts can use a reactor to inject a
not found error.
Signed-off-by: Scott Andrews andrewssc@vmware.com