New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the status contract #198
Conversation
Codecov Report
@@ Coverage Diff @@
## main #198 +/- ##
=======================================
Coverage 64.71% 64.71%
=======================================
Files 8 8
Lines 768 768
=======================================
Hits 497 497
Misses 256 256
Partials 15 15
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, thanks. I left a few suggestions to fix quoting in the json tags.
In practice, I expect resources will have other fields on their status and the direct use will not be common. I'd lean towards removing that example in favor of a custom type the inlines our fields. I don't object to the direct usage example if you think that's common enough.
b219bf7
to
699eabb
Compare
Thank you! I really botched them all. 🤣
That sounds good to me. I changed it accordingly. |
0b7bc03
to
12382e5
Compare
Rebased and fixed up suggestion |
Since it's not immediately clear how
reconciler-runtime
expects a resource's.status
to look like, I thought I'd propose this for theREADME.md
andapi.Status
's doc comment.(reopened after going through the CLA process)