Normalize reconciler name #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All (sub)reconcilers now have a name field. The name will be defaulted during as part of setup if not defined. While name should ideally be unique, the default names likely won't be. The name of each reconciler is added to the logger as its name. There were a couple places during setup where the reconciler name was defaulted after being added to the logger, these have been corrected. Signed-off-by: Scott Andrews <andrewssc@vmware.com>
Signed-off-by: Scott Andrews <andrewssc@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #231 +/- ##
==========================================
- Coverage 65.43% 65.10% -0.34%
==========================================
Files 9 9
Lines 1030 1046 +16
==========================================
+ Hits 674 681 +7
- Misses 334 344 +10
+ Partials 22 21 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All (sub)reconcilers now have a name field. The name will be defaulted
during as part of setup if not defined. While name should ideally be
unique, the default names likely won't be.
The name of each reconciler is added to the logger as its name. There
were a couple places during setup where the reconciler name was
defaulted after being added to the logger, these have been corrected.
Signed-off-by: Scott Andrews andrewssc@vmware.com