Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe form of release_core system call #341

Open
hunhoffe opened this issue Oct 10, 2023 · 0 comments
Open

Safe form of release_core system call #341

hunhoffe opened this issue Oct 10, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@hunhoffe
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Right now, the release_core() system call does not remove/clear an executor from that core (if there is one) so it is up to the process to make sure the core isn't executing anything before making the system call.

Describe the solution you'd like

We probably need to use an interrupt mechanism to clear the core to be released.

Describe alternatives you've considered

You could also make the system call fail (before submitting it to the log, for consistency) if there is an executor running on that core. I'm not sure what mechanism would be best for discerning if there is something running on that core.

Additional context

This feature wasn't added to the initial PR for introducing the release_core() system call due to time constraints; either potential solution shouldn't be too hard to implement.

@hunhoffe hunhoffe added the enhancement New feature or request label Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant