Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbounded TLB WorkQueue #290

Open
hunhoffe opened this issue Apr 5, 2023 · 0 comments
Open

Unbounded TLB WorkQueue #290

hunhoffe opened this issue Apr 5, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@hunhoffe
Copy link
Collaborator

hunhoffe commented Apr 5, 2023

Describe the bug

The TLB WorkQueue is currently not bounded in size. It holds both shootdown requests (which are important to handle) and advance replica work requests (which are less important to handle).

Currently, if the queue is full and enqueue is called the error is ignored:

let _ignore = IPI_WORKQUEUE[gtid as usize].push(s);

If this is uncommented, it becomes clear that some requests may be dropped if the queue is full.

Reproduction steps

  1. Change the line to check for failure to enqueue (use expect to unwrap the result)
  2. Run the fxmark benchmark with 96-ish cores
  3. Most of the time, it will cause an error.

Expected behavior

We would like a scenario where the queue has a theoretical bound, so that we can ensure it is always possible to enqueue. This is an important property because, overall, we just want to make sure shootdowns are not lost.

Additional context

No response

@hunhoffe hunhoffe added the bug Something isn't working label Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant