Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Struct and Reference Struct type mismatch in Struct Default Value #21489

Open
heyimtcn opened this issue May 11, 2024 · 0 comments
Open

Struct and Reference Struct type mismatch in Struct Default Value #21489

heyimtcn opened this issue May 11, 2024 · 0 comments
Labels
Bug This tag is applied to issues which reports bugs.

Comments

@heyimtcn
Copy link

heyimtcn commented May 11, 2024

Describe the bug

Note: Bar must at least have 1 field or it will be interpreted as nil and work

struct Foo {
	bar &Bar = Bar{}
}

struct Bar {
	field int
}

fn main() {
	dump(Foo{})
}

If type Foo.bar is &Bar but is provided Bar it will throw this C error:
/tmp/v_60000/../../../../../../box/code.v:10: error: cannot convert 'struct main__Bar' to 'struct main__Bar *'

If type Foo.bar is Bar but is provided &Bar it will convert &Bar to Bar but Bar's field values will be corrupted like #20969

Reproduction Steps

struct Foo {
	bar &Bar = Bar{}
}

struct Bar {
	field int
}

fn main() {
	dump(Foo{})
}

Expected Behavior

Proper serialisation of the default field values or V error

Current Behavior

If type Foo.bar is &Bar but is provided Bar it will throw this C error:
/tmp/v_60000/../../../../../../box/code.v:10: error: cannot convert 'struct main__Bar' to 'struct main__Bar *'

If type Foo.bar is Bar but is provided &Bar it will convert &Bar to Bar but Bar's field values will be corrupted like #20969

Possible Solution

Whilst default field values don't work, setting them at runtime does, so adding those checks at comptime for default field values might help

Additional Information/Context

Found and tested in V playground

V version

V 0.4.5 0e2b604

Environment details (OS name and version, etc.)

V full version: V 0.4.5 0e2b604
OS: linux, Debian GNU/Linux 11 (bullseye) (VM)
Processor: 1 cpus, 64bit, little endian, Intel(R) Xeon(R) CPU E5-2686 v4 @ 2.30GHz

getwd: /home/admin/playground
vexe: /home/admin/v/v
vexe mtime: 2024-05-11 08:25:23

vroot: OK, value: /home/admin/v
VMODULES: OK, value: .vmodules
VTMP: OK, value: /tmp/v_0

Git version: git version 2.30.2
Git vroot status: Error: fatal: detected dubious ownership in repository at '/home/admin/v'
To add an exception for this directory, call:

	git config --global --add safe.directory /home/admin/v
.git/config present: true

CC version: cc (Debian 10.2.1-6) 10.2.1 20210110
thirdparty/tcc status: Error: fatal: detected dubious ownership in repository at '/home/admin/v/thirdparty/tcc'
To add an exception for this directory, call:

	git config --global --add safe.directory /home/admin/v/thirdparty/tcc
 Error: fatal: detected dubious ownership in repository at '/home/admin/v/thirdparty/tcc'
To add an exception for this directory, call:

	git config --global --add safe.directory /home/admin/v/thirdparty/tcc

Note

You can use the 👍 reaction to increase the issue's priority for developers.

Please note that only the 👍 reaction to the issue itself counts as a vote.
Other reactions and those to comments will not be taken into account.

@heyimtcn heyimtcn added the Bug This tag is applied to issues which reports bugs. label May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This tag is applied to issues which reports bugs.
Projects
None yet
Development

No branches or pull requests

1 participant