Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on Print #203

Closed
joshirio opened this issue Sep 6, 2019 · 11 comments
Closed

Crash on Print #203

joshirio opened this issue Sep 6, 2019 · 11 comments

Comments

@joshirio
Copy link
Contributor

joshirio commented Sep 6, 2019

Printing a mail from ProtonMail webclient causes the entire app to crash when clicking on printing after the print preview dialog. The saved PDF file is still saved entirely on disk, so it looks like it crashes after successful printing.

The log files shows no related entry to this. Tested on Ubuntu and macOS.

@joshirio
Copy link
Contributor Author

joshirio commented Sep 6, 2019

Another issue: the built-in (protonmail) print preview dialog cannot be closed when clicking on close or the close button (nothing happens).

@vladimiry
Copy link
Owner

vladimiry commented Sep 6, 2019

@electron is known to have severe issues with printing, some recent issues:

I keep track of those upstream issues. Besides going to debug the case one day in order to find a workaround.

@vladimiry vladimiry removed the bug label Sep 6, 2019
@vladimiry
Copy link
Owner

The workaround, for now, is to export the email message to EML file, import it to an email client like Thunderbird and print it there.

@vladimiry
Copy link
Owner

Electron team is making some progress on the issue. Looks like they are going to completely resolve it soon.

@BBaoVanC
Copy link

Print to PDF works fine on my MacBook (Catalina, 10.15.2). (ProtonMail 4.0 beta Web UI)
From about page:
ElectronMail v4.2.1
Electron: 7.1.10
Chromium: 78.0.3904.130
Node: 12.8.1
V8: 7.8.279.23-electron.0

@vladimiry
Copy link
Owner

@BBaoVanC does print work for you if you call it 2+ times one by one? There was an issue that printing worked only first time and then if you call it again nothing happened. They fixed it just recently in https://github.com/electron/electron/releases/tag/v7.1.11

@BBaoVanC
Copy link

Yes, it works. Tested 4 times in a row.

@vladimiry
Copy link
Owner

vladimiry commented Jan 30, 2020

Thanks for testing the stuff. You were somewhat lucky getting it to work before it got officially fixed in https://github.com/electron/electron/releases/tag/v7.1.11 😄 It's a good thing but I'm still going to keep the issue open until the app updates to Electron v7.1.11+.

@vladimiry
Copy link
Owner

@joshirio, can you try this build? It comes with just released @electron version 8. I did a brief testing I didn't notice printing issues in this build.

@joshirio
Copy link
Contributor Author

joshirio commented Feb 4, 2020

Printing actually works with v4.2.2, tested on windows and Ubuntu (snap)

@joshirio, can you try this build? It comes with just released @electron version 8

Also works fine. Looks like it was fixed in some recent update :)

@vladimiry
Copy link
Owner

Closing the issue as Electron has finally sorted the problem out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants