Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RelationalBone.setBoneValue doesn't accept db.Key.id_or_name-value #648

Open
phorward opened this issue Feb 8, 2023 · 2 comments · May be fixed by #1081
Open

RelationalBone.setBoneValue doesn't accept db.Key.id_or_name-value #648

phorward opened this issue Feb 8, 2023 · 2 comments · May be fixed by #1081
Assignees
@ArneGudermann
Labels
bug(fix) Something isn't working or address a specific issue or vulnerability feature New feature or request proposal

Comments

@phorward
Copy link
Member

phorward commented Feb 8, 2023

RelationalBone.setBoneValue accepts

  1. str-encoded URL-safe key
  2. db.Key instance

But why not

  1. str or int as id_or_name value, which can be computed as the kind-name is known
@phorward phorward added bug(fix) Something isn't working or address a specific issue or vulnerability feature New feature or request proposal labels Feb 8, 2023
@phorward
Copy link
Member Author

There is some similarity on #1008 for this.

@phorward
Copy link
Member Author

There's also some touchpoints with #1012

@ArneGudermann ArneGudermann pinned this issue Mar 15, 2024
@ArneGudermann ArneGudermann unpinned this issue Mar 15, 2024
@ArneGudermann ArneGudermann linked a pull request Mar 15, 2024 that will close this issue
refactor: relationalBone setBoneValue #1081
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArneGudermann ArneGudermann

Labels
bug(fix) Something isn't working or address a specific issue or vulnerability feature New feature or request proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: relationalBone setBoneValue ArneGudermann/viur-core
2 participants
@phorward @ArneGudermann