Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmarks don't work with browser runner #5041

Closed
6 tasks done
jbms opened this issue Jan 24, 2024 · 3 comments · Fixed by #5622
Closed
6 tasks done

benchmarks don't work with browser runner #5041

jbms opened this issue Jan 24, 2024 · 3 comments · Fixed by #5622
Labels
enhancement New feature or request feat: browser Issues and PRs related to the browser runner p2-to-be-discussed Enhancement under consideration (priority)

Comments

@jbms
Copy link

jbms commented Jan 24, 2024

Describe the bug

Benchmark fails with:

Test function is not found. Did you add it using `setFn`?

Reproduction

https://stackblitz.com/edit/vitest-dev-vitest-qvjudf?file=package.json

System Info

n/a

Used Package Manager

npm

Validations
@hi-ogawa hi-ogawa added feat: browser Issues and PRs related to the browser runner enhancement New feature or request p2-to-be-discussed Enhancement under consideration (priority) and removed pending triage labels Feb 23, 2024
@vekexasia
Copy link

Just happened to me as well. Any news on this?

@jacomyal
Copy link

jacomyal commented Apr 3, 2024

It would be so great to have such a simple tool for benchmarking scripts in a browser environment! Any news on this?

@hi-ogawa hi-ogawa mentioned this issue Apr 26, 2024
Merged
7 tasks
@jacomyal
Copy link

jacomyal commented May 2, 2024

That is so awesome, thank you very much ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request feat: browser Issues and PRs related to the browser runner p2-to-be-discussed Enhancement under consideration (priority)
Projects
Team Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(browser): support benchmark hi-ogawa/vitest
4 participants
@jacomyal @vekexasia @jbms @hi-ogawa