Source maps in inlined deps are off by a few lines in VS Code #5605

bgoscinski · 2024-04-23T19:50:57Z

Describe the bug

Source maps in inlined deps are off by a few lines in VS Code debugger

Reproduction

https://github.com/bgoscinski/repro-vitest-sourcemap

pnpm install
code test/the.test.ts
Set breakpoint at line 3 of the test file
Start debugging session using 'Debug' configuration
Wait for debugger to attach
Press 'Step into' until you're in add function implementation
Press 'Step over' and see that debugger highlights invalid line

2024-04-23_21-19-51.mp4

System Info

System:
    OS: Windows 11 10.0.22000
    CPU: (16) x64 12th Gen Intel(R) Core(TM) i7-1260P
    Memory: 19.73 GB / 47.70 GB
  Binaries:
    Node: 18.16.0 - C:\Program Files\nodejs\node.EXE
    npm: 9.8.1 - C:\Program Files\nodejs\npm.CMD
    pnpm: 8.15.6 - ~\AppData\Roaming\npm\pnpm.CMD
    bun: 1.1.1 - ~\.bun\bin\bun.EXE
  Browsers:
    Edge: Spartan (44.22000.120.0), Chromium (123.0.2420.97)
  npmPackages:
    @vitest/ui: latest => 1.5.0
    vite: latest => 5.2.10
    vitest: latest => 1.5.0

Used Package Manager

pnpm

Validations

Follow our Code of Conduct
Read the Contributing Guidelines.
Read the docs.
Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
The provided reproduction is a minimal reproducible example of the bug.

The text was updated successfully, but these errors were encountered:

AriPerkkio · 2024-04-24T04:43:56Z

Could you point out the incorrect source map? You can use vite-plugin-inspect or VITE_NODE_DEBUG_DUMP=1 vitest to capture the source maps. Note that VITE_NODE_DEBUG_DUMP adds a comment on top of the file - you'll need to remove that manually before using it.

bgoscinski · 2024-04-24T11:50:51Z

Running VITE_NODE_DEBUG_DUMP=1 npx vitest run generated a bunch of files in .vite-node/dump folder. Turns out that none of the files coming from node_modules have source maps. Here's a sample:

.vite-node/dump/_node_modules_pnpm_date-fns@3_6_0_node_modules_date-fns_add_mjs--115640895.js

// /node_modules/.pnpm/date-fns@3.6.0/node_modules/date-fns/add.mjs
const __vite_ssr_import_0__ = await __vite_ssr_import__("/node_modules/.pnpm/date-fns@3.6.0/node_modules/date-fns/addDays.mjs", {"importedNames":["addDays"]});
const __vite_ssr_import_1__ = await __vite_ssr_import__("/node_modules/.pnpm/date-fns@3.6.0/node_modules/date-fns/addMonths.mjs", {"importedNames":["addMonths"]});
const __vite_ssr_import_2__ = await __vite_ssr_import__("/node_modules/.pnpm/date-fns@3.6.0/node_modules/date-fns/constructFrom.mjs", {"importedNames":["constructFrom"]});
const __vite_ssr_import_3__ = await __vite_ssr_import__("/node_modules/.pnpm/date-fns@3.6.0/node_modules/date-fns/toDate.mjs", {"importedNames":["toDate"]});





/**
 * @name add
 * @category Common Helpers
 * @summary Add the specified years, months, weeks, days, hours, minutes and seconds to the given date.
 *
 * @description
 * Add the specified years, months, weeks, days, hours, minutes and seconds to the given date.
 *
 * @typeParam DateType - The `Date` type, the function operates on. Gets inferred from passed arguments. Allows to use extensions like [`UTCDate`](https://github.com/date-fns/utc).
 *
 * @param date - The date to be changed
 * @param duration - The object with years, months, weeks, days, hours, minutes and seconds to be added.
 *
 * | Key            | Description                        |
 * |----------------|------------------------------------|
 * | years          | Amount of years to be added        |
 * | months         | Amount of months to be added       |
 * | weeks          | Amount of weeks to be added        |
 * | days           | Amount of days to be added         |
 * | hours          | Amount of hours to be added        |
 * | minutes        | Amount of minutes to be added      |
 * | seconds        | Amount of seconds to be added      |
 *
 * All values default to 0
 *
 * @returns The new date with the seconds added
 *
 * @example
 * // Add the following duration to 1 September 2014, 10:19:50
 * const result = add(new Date(2014, 8, 1, 10, 19, 50), {
 *   years: 2,
 *   months: 9,
 *   weeks: 1,
 *   days: 7,
 *   hours: 5,\\-7
 *   minutes: 9,
 *   seconds: 30,
 * })
 * //=> Thu Jun 15 2017 15:29:20
 */
function add(date, duration) {
  const {
    years = 0,
    months = 0,
    weeks = 0,
    days = 0,
    hours = 0,
    minutes = 0,
    seconds = 0,
  } = duration;

  // Add years and months
  const _date = __vite_ssr_import_3__.toDate(date);
  const dateWithMonths =
    months || years ? __vite_ssr_import_1__.addMonths(_date, months + years * 12) : _date;

  // Add weeks and days
  const dateWithDays =
    days || weeks ? __vite_ssr_import_0__.addDays(dateWithMonths, days + weeks * 7) : dateWithMonths;

  // Add days, hours, minutes and seconds
  const minutesToAdd = minutes + hours * 60;
  const secondsToAdd = seconds + minutesToAdd * 60;
  const msToAdd = secondsToAdd * 1000;
  const finalDate = __vite_ssr_import_2__.constructFrom(date, dateWithDays.getTime() + msToAdd);

  return finalDate;
}
Object.defineProperty(__vite_ssr_exports__, "add", { enumerable: true, configurable: true, get(){ return add }});

// Fallback for modularized imports:
__vite_ssr_exports__.default = add;

I even tried doing this 👇 but it didn't change anything

diff --git a/vite.config.ts b/vite.config.ts
index 673c4de..2ffa6df 100644
--- a/vite.config.ts
+++ b/vite.config.ts
@@ -7,6 +7,7 @@ import { defineConfig } from 'vite'
 export default defineConfig({
   test: {
     server: {
+      sourcemap: 'inline',
       deps: {
         inline: ['date-fns']
       }

bgoscinski · 2024-04-26T14:28:30Z

I figured that when I change this

vitest/packages/vite-node/src/server.ts

Lines 307 to 309 in 48fba19

    
           const sourcemap = this.options.sourcemap ?? 'inline' 
        
           if (sourcemap === 'inline' && result && !id.includes('node_modules')) 
        
             result = await this.processTransformResult(filepath, result)

in this way:

     const sourcemap = this.options.sourcemap ?? 'inline'
-    if (sourcemap === 'inline' && result && !id.includes('node_modules'))
+    if (sourcemap === 'inline' && result && !(await this.shouldExternalize(id)))
       result = await this.processTransformResult(filepath, result)

Then running with VITE_NODE_DEBUG_DUMP=1 will spit out files with source map. Here's the output for add.mjs that I got with the above change:

.vite-node/dump/_node_modules_pnpm_date-fns@3_6_0_node_modules_date-fns_add_mjs--115640895.js

// /node_modules/.pnpm/date-fns@3.6.0/node_modules/date-fns/add.mjs
const __vite_ssr_import_0__ = await __vite_ssr_import__("/node_modules/.pnpm/date-fns@3.6.0/node_modules/date-fns/addDays.mjs", {"importedNames":["addDays"]});
const __vite_ssr_import_1__ = await __vite_ssr_import__("/node_modules/.pnpm/date-fns@3.6.0/node_modules/date-fns/addMonths.mjs", {"importedNames":["addMonths"]});
const __vite_ssr_import_2__ = await __vite_ssr_import__("/node_modules/.pnpm/date-fns@3.6.0/node_modules/date-fns/constructFrom.mjs", {"importedNames":["constructFrom"]});
const __vite_ssr_import_3__ = await __vite_ssr_import__("/node_modules/.pnpm/date-fns@3.6.0/node_modules/date-fns/toDate.mjs", {"importedNames":["toDate"]});





/**
 * @name add
 * @category Common Helpers
 * @summary Add the specified years, months, weeks, days, hours, minutes and seconds to the given date.
 *
 * @description
 * Add the specified years, months, weeks, days, hours, minutes and seconds to the given date.
 *
 * @typeParam DateType - The `Date` type, the function operates on. Gets inferred from passed arguments. Allows to use extensions like [`UTCDate`](https://github.com/date-fns/utc).
 *
 * @param date - The date to be changed
 * @param duration - The object with years, months, weeks, days, hours, minutes and seconds to be added.
 *
 * | Key            | Description                        |
 * |----------------|------------------------------------|
 * | years          | Amount of years to be added        |
 * | months         | Amount of months to be added       |
 * | weeks          | Amount of weeks to be added        |
 * | days           | Amount of days to be added         |
 * | hours          | Amount of hours to be added        |
 * | minutes        | Amount of minutes to be added      |
 * | seconds        | Amount of seconds to be added      |
 *
 * All values default to 0
 *
 * @returns The new date with the seconds added
 *
 * @example
 * // Add the following duration to 1 September 2014, 10:19:50
 * const result = add(new Date(2014, 8, 1, 10, 19, 50), {
 *   years: 2,
 *   months: 9,
 *   weeks: 1,
 *   days: 7,
 *   hours: 5,\\-7
 *   minutes: 9,
 *   seconds: 30,
 * })
 * //=> Thu Jun 15 2017 15:29:20
 */
function add(date, duration) {
  const {
    years = 0,
    months = 0,
    weeks = 0,
    days = 0,
    hours = 0,
    minutes = 0,
    seconds = 0,
  } = duration;

  // Add years and months
  const _date = __vite_ssr_import_3__.toDate(date);
  const dateWithMonths =
    months || years ? __vite_ssr_import_1__.addMonths(_date, months + years * 12) : _date;

  // Add weeks and days
  const dateWithDays =
    days || weeks ? __vite_ssr_import_0__.addDays(dateWithMonths, days + weeks * 7) : dateWithMonths;

  // Add days, hours, minutes and seconds
  const minutesToAdd = minutes + hours * 60;
  const secondsToAdd = seconds + minutesToAdd * 60;
  const msToAdd = secondsToAdd * 1000;
  const finalDate = __vite_ssr_import_2__.constructFrom(date, dateWithDays.getTime() + msToAdd);

  return finalDate;
}
Object.defineProperty(__vite_ssr_exports__, "add", { enumerable: true, configurable: true, get(){ return add }});

// Fallback for modularized imports:
__vite_ssr_exports__.default = add;

//# sourceMappingSource=vite-node
//# sourceMappingURL=data:application/json;charset=utf-8;base64,{"version":3,"sources":["add.mjs"],"sourcesContent":["import { addDays } from \"./addDays.mjs\";\nimport { addMonths } from \"./addMonths.mjs\";\nimport { constructFrom } from \"./constructFrom.mjs\";\nimport { toDate } from \"./toDate.mjs\";\n\n/**\n * @name add\n * @category Common Helpers\n * @summary Add the specified years, months, weeks, days, hours, minutes and seconds to the given date.\n *\n * @description\n * Add the specified years, months, weeks, days, hours, minutes and seconds to the given date.\n *\n * @typeParam DateType - The `Date` type, the function operates on. Gets inferred from passed arguments. Allows to use extensions like [`UTCDate`](https://github.com/date-fns/utc).\n *\n * @param date - The date to be changed\n * @param duration - The object with years, months, weeks, days, hours, minutes and seconds to be added.\n *\n * | Key            | Description                        |\n * |----------------|------------------------------------|\n * | years          | Amount of years to be added        |\n * | months         | Amount of months to be added       |\n * | weeks          | Amount of weeks to be added        |\n * | days           | Amount of days to be added         |\n * | hours          | Amount of hours to be added        |\n * | minutes        | Amount of minutes to be added      |\n * | seconds        | Amount of seconds to be added      |\n *\n * All values default to 0\n *\n * @returns The new date with the seconds added\n *\n * @example\n * // Add the following duration to 1 September 2014, 10:19:50\n * const result = add(new Date(2014, 8, 1, 10, 19, 50), {\n *   years: 2,\n *   months: 9,\n *   weeks: 1,\n *   days: 7,\n *   hours: 5,\\\\-7\n *   minutes: 9,\n *   seconds: 30,\n * })\n * //=> Thu Jun 15 2017 15:29:20\n */\nexport function add(date, duration) {\n  const {\n    years = 0,\n    months = 0,\n    weeks = 0,\n    days = 0,\n    hours = 0,\n    minutes = 0,\n    seconds = 0,\n  } = duration;\n\n  // Add years and months\n  const _date = toDate(date);\n  const dateWithMonths =\n    months || years ? addMonths(_date, months + years * 12) : _date;\n\n  // Add weeks and days\n  const dateWithDays =\n    days || weeks ? addDays(dateWithMonths, days + weeks * 7) : dateWithMonths;\n\n  // Add days, hours, minutes and seconds\n  const minutesToAdd = minutes + hours * 60;\n  const secondsToAdd = seconds + minutesToAdd * 60;\n  const msToAdd = secondsToAdd * 1000;\n  const finalDate = constructFrom(date, dateWithDays.getTime() + msToAdd);\n\n  return finalDate;\n}\n\n// Fallback for modularized imports:\nexport default add;\n"],"names":[],"mappings":"AAAA,CAAA;;;;AAA+F;AACI;AACQ;AACd;AAC7F;AACA,CAAC,CAAC,CAAC;AACH,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,GAAG;AACZ,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,MAAM,CAAC,OAAO;AAC3B,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,GAAG,CAAC,GAAG,CAAC,SAAS,CAAC,KAAK,CAAC,CAAC,MAAM,CAAC,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,CAAC,KAAK,CAAC,CAAC,OAAO,CAAC,GAAG,CAAC,OAAO,CAAC,EAAE,CAAC,GAAG,CAAC,KAAK,CAAC,IAAI,CAAC;AACvG,CAAC,CAAC;AACF,CAAC,CAAC,CAAC,CAAC,WAAW;AACf,CAAC,CAAC,CAAC,GAAG,CAAC,GAAG,CAAC,SAAS,CAAC,KAAK,CAAC,CAAC,MAAM,CAAC,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,CAAC,KAAK,CAAC,CAAC,OAAO,CAAC,GAAG,CAAC,OAAO,CAAC,EAAE,CAAC,GAAG,CAAC,KAAK,CAAC,IAAI,CAAC;AAC9F,CAAC,CAAC;AACF,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,QAAQ,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,CAAC,GAAG,CAAC,QAAQ,CAAC,QAAQ,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC,MAAM,CAAC,EAAE,CAAC,GAAG,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,MAAM,CAAC,GAAG,CAAC,IAAI,CAAC,GAAG,CAAC,GAAG,CAAC,CAAC;AACpL,CAAC,CAAC;AACF,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,CAAC,EAAE,CAAC,OAAO;AACvC,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAC,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,MAAM,CAAC,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,CAAC,KAAK,CAAC,CAAC,OAAO,CAAC,GAAG,CAAC,OAAO,CAAC,EAAE,CAAC,EAAE,CAAC,KAAK,CAAC;AACxG,CAAC,CAAC;AACF,CAAC,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,WAAW,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;AAC1D,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;AAC1D,CAAC,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,EAAE,CAAC,KAAK,CAAC,EAAE,CAAC,EAAE,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;AAC1D,CAAC,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,EAAE,CAAC,MAAM,CAAC,EAAE,CAAC,EAAE,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;AAC1D,CAAC,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,EAAE,CAAC,KAAK,CAAC,EAAE,CAAC,EAAE,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;AAC1D,CAAC,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,EAAE,CAAC,IAAI,CAAC,EAAE,CAAC,EAAE,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;AAC1D,CAAC,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,EAAE,CAAC,KAAK,CAAC,EAAE,CAAC,EAAE,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;AAC1D,CAAC,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,EAAE,CAAC,OAAO,CAAC,EAAE,CAAC,EAAE,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;AAC1D,CAAC,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,EAAE,CAAC,OAAO,CAAC,EAAE,CAAC,EAAE,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;AAC1D,CAAC,CAAC;AACF,CAAC,CAAC,CAAC,GAAG,CAAC,MAAM,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;AAC1B,CAAC,CAAC;AACF,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,GAAG,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,CAAC,OAAO,CAAC,KAAK;AAC/C,CAAC,CAAC;AACF,CAAC,CAAC,CAAC,CAAC,OAAO;AACX,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,GAAG,CAAC,SAAS,CAAC,QAAQ,CAAC,EAAE,CAAC,CAAC,CAAC,SAAS,CAAC,IAAI,CAAC,CAAC,EAAE,CAAC,EAAE,CAAC,EAAE;AAC9D,CAAC,CAAC,CAAC,KAAK,CAAC,MAAM,CAAC,CAAC,CAAC,GAAG,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,EAAE,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC;AACzD,CAAC,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC;AACd,CAAC,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC;AACf,CAAC,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC;AACd,CAAC,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;AACb,CAAC,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;AAClB,CAAC,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC;AAChB,CAAC,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,EAAE,CAAC;AACjB,CAAC,CAAC,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,GAAG,CAAC,EAAE,CAAC,IAAI,CAAC,EAAE,CAAC,EAAE,CAAC,EAAE;AAChC,CAAC,CAAC,CAAC;AACI,QAAQ,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC,QAAQ,CAAC,CAAC,CAAC;AACrC,CAAC,CAAC,KAAK,CAAC,CAAC;AACT,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC;AACd,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,CAAC;AACf,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC;AACd,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,CAAC;AACb,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC;AACd,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,CAAC;AAChB,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,CAAC;AAChB,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC;AACf;AACA,CAAC,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,KAAK,CAAC,GAAG,CAAC,MAAM;AACzB,CAAC,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC,CAAC,4BAAM,CAAC,IAAI,CAAC,CAAC;AAC7B,CAAC,CAAC,KAAK,CAAC,cAAc,CAAC,CAAC;AACxB,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,+BAAS,CAAC,KAAK,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC;AACpE;AACA,CAAC,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,KAAK,CAAC,GAAG,CAAC,IAAI;AACvB,CAAC,CAAC,KAAK,CAAC,YAAY,CAAC,CAAC;AACtB,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,6BAAO,CAAC,cAAc,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,cAAc,CAAC;AAC/E;AACA,CAAC,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC,KAAK,CAAC,CAAC,OAAO,CAAC,GAAG,CAAC,OAAO;AACzC,CAAC,CAAC,KAAK,CAAC,YAAY,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,EAAE,CAAC;AAC5C,CAAC,CAAC,KAAK,CAAC,YAAY,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,EAAE,CAAC;AACnD,CAAC,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,IAAI,CAAC;AACtC,CAAC,CAAC,KAAK,CAAC,SAAS,CAAC,CAAC,CAAC,mCAAa,CAAC,IAAI,CAAC,CAAC,YAAY,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC;AAC1E;AACA,CAAC,CAAC,MAAM,CAAC,SAAS,CAAC;AACnB;iHAAC;AACD;AACA,CAAC,CAAC,CAAC,QAAQ,CAAC,GAAG,CAAC,WAAW,CAAC,OAAO,CAAC;AACpC,8BAAc,CAAC,GAAG,CAAC;"}

I put this file into Source map visualization tool and, taking into account the comment line added by VITE_NODE_DEBUG_DUMP at the top, it seems to be generating a correct sourcemap.

Sadly, this doesn't help VS Code in any way. It still points at line 52 just after stepping into the add function :(

@AriPerkkio do you have any more pointers?

AriPerkkio · 2024-04-28T10:26:53Z

@bgoscinski could you show in a recording how this should behave when running without Vitest? Use file like below with VSCode's debugger:

import { add } from "date-fns";

add(0, { days: 1 });

vscode-date-fns-debugger.mov

Does it work any better if you disable VSCode's "Pretty print for debugging" option?

AriPerkkio · 2024-04-28T10:37:58Z

Chrome Devtools with vitest --inspect-brk seems to work correctly even without the proposed fix of #5605 (comment).

bgoscinski · 2024-04-28T17:11:28Z

@AriPerkkio Sure! Here's how it works without vitest/how it should work:

debug-node.mp4

I updated reproduction repo with launch script. See bgoscinski/repro-vitest-sourcemap@42e048b

Does it work any better if you disable VSCode's "Pretty print for debugging" option?

Clicking this doesn't seem to do anything

Chrome Devtools with vitest --inspect-brk seems to work correctly even without the proposed fix of #5605 (comment).

Good to know, however switching to chrome devtools breaks my flow :(

AriPerkkio · 2024-04-28T17:48:22Z

Sure! Here's how it works without vitest/how it should work

Using your reproduction in fresh Github Codespaces I'm unable to set breakpoints like shown in the video above. 🤷

Screen.Recording.2024-04-28.at.20.52.40.mov

bgoscinski · 2024-04-28T18:11:10Z

Yeah, in Github Codespaces I get the same result as you do... Could you try in "normal" vscode?

Edit:
I think Github Codespaces treats the whole destructuring assignment as a "atomic" thing so, when we run with Debug - node and "step into" the add function we land on line 48 (correct), and then "step over" for some reason goes directly to the next line that we can pause on - line 58 (the one with assignment to _date). I guess that's mostly fine because at least it stops at lines that it's about to execute.

Anyway, when I launch "Debug - vitest" script it breaks the same way as my local vscode installation:

Running without vitest in Codespaces:

2024-04-28_20-32-54.mp4

Running with vitest in Codespaces:

2024-04-28_20-31-16.mp4

AriPerkkio · 2024-04-29T04:59:11Z

Yeah, in Github Codespaces I get the same result as you do... Could you try in "normal" vscode?

I get the same results on local VSCode and Github Codespaces.

But I can reproduce the issue shown on videos of #5605 (comment). Debugger lands on incorrect lines (L52,L62) - looks like there's some offset that's probably caused by Vite's transforms that are not included in source maps. Or rather the file is transformed but no source maps have been generated like shown in #5605 (comment).

Let's focus on making the debugger land on same lines (L48,L58) when used with Vitest. Breakpoints in the destructured object L47-L55 work so inconsistenly even without Vitest that we shouldn't focus on those right now.

AriPerkkio · 2024-04-29T18:09:34Z

Removing columnOffset from vm.runInThisContext seems to fix this:

vitest/packages/vite-node/src/client.ts

Lines 419 to 425 in becabb5

    
           const options = { 
        
             filename: context.__filename, 
        
             lineOffset: 0, 
        
             columnOffset: -codeDefinition.length, 
        
           } 
        
           const fn = vm.runInThisContext(code, options)

@sheremet-va that one is used for getting proper stack traces, right?

bgoscinski · 2024-04-29T20:28:22Z

@AriPerkkio Thanks for looking into it but I'm afraid it breaks the source mapping even more. See the video below and notice that with columnOffset path to the add.mjs uses forward slashes and shows the real contents of the add.mjs file from node_modules - the one with ESM imports. Without columnOffset the file has path consisting of backslashes and it starts with a backslash. VSCode opens it in a new tab as if it was a different file from "the real" add.mjs in node_modules. It also shows transformed __vite_ssr_import__ calls instead of original ESM imports :(

2024-04-29_22-17-34.mp4

AriPerkkio · 2024-05-05T19:07:13Z

Spent couple of more hours looking into this and I have no idea how to fix this. Even when source maps are enabled for the inlined deps, VSCode will not follow them. I also tried to apply vite-node's wrapper in those source maps and it still didn't work. Not sure what to try next. Maybe if Vite's SSR transform didn't change the file's line count it could work automatically. Right now SSR transform may add some extra lines.

bgoscinski added the pending triage label Apr 23, 2024

AriPerkkio added the help wanted Extra attention is needed label Apr 28, 2024

AriPerkkio added mode: ssr p3-minor-bug An edge case that only affects very specific usage (priority) and removed pending triage labels Apr 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source maps in inlined deps are off by a few lines in VS Code #5605

Source maps in inlined deps are off by a few lines in VS Code #5605

bgoscinski commented Apr 23, 2024

AriPerkkio commented Apr 24, 2024 •

edited

bgoscinski commented Apr 24, 2024

bgoscinski commented Apr 26, 2024

AriPerkkio commented Apr 28, 2024 •

edited

AriPerkkio commented Apr 28, 2024

bgoscinski commented Apr 28, 2024 •

edited

AriPerkkio commented Apr 28, 2024 •

edited

bgoscinski commented Apr 28, 2024 •

edited

AriPerkkio commented Apr 29, 2024 •

edited

AriPerkkio commented Apr 29, 2024

bgoscinski commented Apr 29, 2024 •

edited

AriPerkkio commented May 5, 2024 •

edited

Source maps in inlined deps are off by a few lines in VS Code #5605

Source maps in inlined deps are off by a few lines in VS Code #5605

Comments

bgoscinski commented Apr 23, 2024

Describe the bug

Reproduction

System Info

Used Package Manager

Validations

AriPerkkio commented Apr 24, 2024 • edited

bgoscinski commented Apr 24, 2024

bgoscinski commented Apr 26, 2024

AriPerkkio commented Apr 28, 2024 • edited

AriPerkkio commented Apr 28, 2024

bgoscinski commented Apr 28, 2024 • edited

AriPerkkio commented Apr 28, 2024 • edited

bgoscinski commented Apr 28, 2024 • edited

Running without vitest in Codespaces:

Running with vitest in Codespaces:

AriPerkkio commented Apr 29, 2024 • edited

AriPerkkio commented Apr 29, 2024

bgoscinski commented Apr 29, 2024 • edited

AriPerkkio commented May 5, 2024 • edited

AriPerkkio commented Apr 24, 2024 •

edited

AriPerkkio commented Apr 28, 2024 •

edited

bgoscinski commented Apr 28, 2024 •

edited

AriPerkkio commented Apr 28, 2024 •

edited

bgoscinski commented Apr 28, 2024 •

edited

AriPerkkio commented Apr 29, 2024 •

edited

bgoscinski commented Apr 29, 2024 •

edited

AriPerkkio commented May 5, 2024 •

edited