Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .next and .turbo to defaultExclude #5579

Open
4 tasks done
domdomegg opened this issue Apr 21, 2024 · 0 comments
Open
4 tasks done

Add .next and .turbo to defaultExclude #5579

domdomegg opened this issue Apr 21, 2024 · 0 comments

Comments

@domdomegg
Copy link

Clear and concise description of the problem

As a developer using Vitest I want common build outputs created excluded so that duplicate versions of tests don't run, and it's easier to get set up without having to provide more config.

Currently the defaultExclude has rules for karma, rollup, webpack, vite, vitest, jest, ava, babel, nyc, cypress, tsup, eslint and prettier.

I would argue that both next and turbo are projects with higher usage levels than some in this list, and therefore it's reasonable to include them.

Suggested solution

+export const defaultExclude = ['**/node_modules/**', '**/dist/**', '**/cypress/**', '**/.{idea,git,cache,output,temp,next,turbo}/**', '**/{karma,rollup,webpack,vite,vitest,jest,ava,babel,nyc,cypress,tsup,build,eslint,prettier}.config.*']
-export const defaultExclude = ['**/node_modules/**', '**/dist/**', '**/cypress/**', '**/.{idea,git,cache,output,temp}/**', '**/{karma,rollup,webpack,vite,vitest,jest,ava,babel,nyc,cypress,tsup,build,eslint,prettier}.config.*']

Alternative

Tell users to manually exclude these files.

Additional context

I'm happy to submit a PR for this.

Validations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant