Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customize Error Serializer #5487

Closed
4 tasks done
moroine opened this issue Apr 4, 2024 · 5 comments · Fixed by #5526
Closed
4 tasks done

Customize Error Serializer #5487

moroine opened this issue Apr 4, 2024 · 5 comments · Fixed by #5526
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)

Comments

@moroine
Copy link

moroine commented Apr 4, 2024 •
edited by hi-ogawa

Clear and concise description of the problem

I have issue with the default serialized error, especially with MongoError. Here is a sample error output:

Notes:

  • I have formatted manually because default doesn't have newlines, which helps a lot to understand the issue
  • I have trimmed the output to fit github comment limit
Show Error 
{
  errorResponse: {
    message: "Document failed validation",
    code: 121,
    writeErrors: [
      {
        err: {
          index: +0,
          code: 121,
          errmsg: "Document failed validation",
          errInfo: {
            failingDocumentId: {
              buffer: {
                sub_type: +0,
                buffer: {
                  "0": 100,
                  "1": 49,
                  "2": 227,
                  "3": 224,
                  "4": 180,
                  "5": 126,
                  "6": 3,
                  "7": 141,
                  "8": 93,
                  "9": 18,
                  "10": 253,
                  "11": 242,
                  constructor: "Function<Buffer>",
                  readBigUInt64LE: "Function<readBigUInt64LE>",
                  readBigUInt64BE: "Function<readBigUInt64BE>",
                  readBigUint64LE: "Function<readBigUInt64LE>",
                  readBigUint64BE: "Function<readBigUInt64BE>",
                  readBigInt64LE: "Function<readBigInt64LE>",
                  readBigInt64BE: "Function<readBigInt64BE>",
                  writeBigUInt64LE: "Function<writeBigUInt64LE>",
                  writeBigUInt64BE: "Function<writeBigUInt64BE>",
                  writeBigUint64LE: "Function<writeBigUInt64LE>",
                  writeBigUint64BE: "Function<writeBigUInt64BE>",
                  writeBigInt64LE: "Function<writeBigInt64LE>",
                  writeBigInt64BE: "Function<writeBigInt64BE>",
                  readUIntLE: "Function<readUIntLE>",
                  readUInt32LE: "Function<readUInt32LE>",
                  readUInt16LE: "Function<readUInt16LE>",
                  readUInt8: "Function<readUInt8>",
                  readUIntBE: "Function<readUIntBE>",
                  readUInt32BE: "Function<readUInt32BE>",
                  readUInt16BE: "Function<readUInt16BE>",
                  readUintLE: "Function<readUIntLE>",
                  readUint32LE: "Function<readUInt32LE>",
                  readUint16LE: "Function<readUInt16LE>",
                  readUint8: "Function<readUInt8>",
                  readUintBE: "Function<readUIntBE>",
                  readUint32BE: "Function<readUInt32BE>",
                  readUint16BE: "Function<readUInt16BE>",
                  readIntLE: "Function<readIntLE>",
                  readInt32LE: "Function<readInt32LE>",
                  readInt16LE: "Function<readInt16LE>",
                  readInt8: "Function<readInt8>",
                  readIntBE: "Function<readIntBE>",
                  readInt32BE: "Function<readInt32BE>",
                  readInt16BE: "Function<readInt16BE>",
                  writeUIntLE: "Function<writeUIntLE>",
                  writeUInt32LE: "Function<writeUInt32LE>",
                  writeUInt16LE: "Function<writeUInt16LE>",
                  writeUInt8: "Function<writeUInt8>",
                  writeUIntBE: "Function<writeUIntBE>",
                  writeUInt32BE: "Function<writeUInt32BE>",
                  writeUInt16BE: "Function<writeUInt16BE>",
                  writeUintLE: "Function<writeUIntLE>",
                  writeUint32LE: "Function<writeUInt32LE>",
                  writeUint16LE: "Function<writeUInt16LE>",
                  writeUint8: "Function<writeUInt8>",
                  writeUintBE: "Function<writeUIntBE>",
                  writeUint32BE: "Function<writeUInt32BE>",
                  writeUint16BE: "Function<writeUInt16BE>",
                  writeIntLE: "Function<writeIntLE>",
                  writeInt32LE: "Function<writeInt32LE>",
                  writeInt16LE: "Function<writeInt16LE>",
                  writeInt8: "Function<writeInt8>",
                  writeIntBE: "Function<writeIntBE>",
                  writeInt32BE: "Function<writeInt32BE>",
                  writeInt16BE: "Function<writeInt16BE>",
                  readFloatLE: "Function<readFloatForwards>",
                  readFloatBE: "Function<readFloatBackwards>",
                  readDoubleLE: "Function<readDoubleForwards>",
                  readDoubleBE: "Function<readDoubleBackwards>",
                  writeFloatLE: "Function<writeFloatForwards>",
                  writeFloatBE: "Function<writeFloatBackwards>",
                  writeDoubleLE: "Function<writeDoubleForwards>",
                  writeDoubleBE: "Function<writeDoubleBackwards>",
                  asciiSlice: "Function<asciiSlice>",
                  base64Slice: "Function<base64Slice>",
                  base64urlSlice: "Function<base64urlSlice>",
                  latin1Slice: "Function<latin1Slice>",
                  hexSlice: "Function<hexSlice>",
                  ucs2Slice: "Function<ucs2Slice>",
                  utf8Slice: "Function<utf8Slice>",
                  asciiWrite: "Function<asciiWrite>",
                  base64Write: "Function<base64Write>",
                  base64urlWrite: "Function<base64urlWrite>",
                  latin1Write: "Function<latin1Write>",
                  hexWrite: "Function<hexWrite>",
                  ucs2Write: "Function<ucs2Write>",
                  utf8Write: "Function<utf8Write>",
                  parent: {
                    constructor: "Function<ArrayBuffer>",
                    byteLength: 8192,
                    slice: "Function<slice>",
                    maxByteLength: 8192,
                    resizable: false,
                    resize: "Function<resize>",
                  },
                  offset: 5345,
                  copy: "Function<copy>",
                  toString: "Function<toString>",
                  equals: "Function<equals>",
                  inspect: "Function<inspect>",
                  compare: "Function<compare>",
                  indexOf: "Function<indexOf>",
                  lastIndexOf: "Function<lastIndexOf>",
                  includes: "Function<includes>",
                  fill: "Function<fill>",
                  write: "Function<write>",
                  toJSON: "Function<toJSON>",
                  subarray: "Function<subarray>",
                  slice: "Function<slice>",
                  swap16: "Function<swap16>",
                  swap32: "Function<swap32>",
                  swap64: "Function<swap64>",
                  toLocaleString: "Function<toString>",
                  BYTES_PER_ELEMENT: 1,
                  buffer: {
                    constructor: "Function<ArrayBuffer>",
                    byteLength: 8192,
                    slice: "Function<slice>",
                    maxByteLength: 8192,
                    resizable: false,
                    resize: "Function<resize>",
                  },
                  byteLength: 12,
                  byteOffset: 5345,
                  length: 12,
                  entries: "Function<entries>",
                  keys: "Function<keys>",
                  values: "Function<values>",
                  at: "Function<at>",
                  copyWithin: "Function<copyWithin>",
                  every: "Function<every>",
                  filter: "Function<filter>",
                  find: "Function<find>",
                  findIndex: "Function<findIndex>",
                  findLast: "Function<findLast>",
                  findLastIndex: "Function<findLastIndex>",
                  forEach: "Function<forEach>",
                  join: "Function<join>",
                  map: "Function<map>",
                  reverse: "Function<reverse>",
                  reduce: "Function<reduce>",
                  reduceRight: "Function<reduceRight>",
                  set: "Function<set>",
                  some: "Function<some>",
                  sort: "Function<sort>",
                  toReversed: "Function<toReversed>",
                  toSorted: "Function<toSorted>",
                  with: "Function<with>",
                },
                position: 12,
                constructor: "Function<Binary>",
                _bsontype: "Binary",
                put: "Function<put>",
                write: "Function<write>",
                read: "Function<read>",
                value: "Function<value>",
                length: "Function<length>",
                toJSON: "Function<toJSON>",
                toString: "Function<toString>",
                toExtendedJSON: "Function<toExtendedJSON>",
                toUUID: "Function<toUUID>",
                inspect: "Function<inspect>",
              },
            },
            details: {
              operatorName: "$jsonSchema",
              title: "source.kit_apprentissage validation schema",
              schemaRulesNotSatisfied: [
                {
                  operatorName: "properties",
                  propertiesNotSatisfied: [
                    {
                      propertyName: "_id",
                      details: [
                        {
                          operatorName: "bsonType",
                          specifiedAs: { bsonType: "objectId" },
                          reason: "type did not match",
                          consideredValue: {
                            buffer: {
                              sub_type: +0,
                              buffer: {
                                "0": 100,
                                "1": 49,
                                "2": 227,
                                "3": 224,
                                "4": 180,
                                "5": 126,
                                "6": 3,
                                "7": 141,
                                "8": 93,
                                "9": 18,
                                "10": 253,
                                "11": 242,
                                constructor: "Function<Buffer>",
                                readBigUInt64LE: "Function<readBigUInt64LE>",
                                readBigUInt64BE: "Function<readBigUInt64BE>",
                                readBigUint64LE: "Function<readBigUInt64LE>",
                                readBigUint64BE: "Function<readBigUInt64BE>",
                                readBigInt64LE: "Function<readBigInt64LE>",
                                readBigInt64BE: "Function<readBigInt64BE>",
                                writeBigUInt64LE: "Function<writeBigUInt64LE>",
                                writeBigUInt64BE: "Function<writeBigUInt64BE>",
                                writeBigUint64LE: "Function<writeBigUInt64LE>",
                                writeBigUint64BE: "Function<writeBigUInt64BE>",
                                writeBigInt64LE: "Function<writeBigInt64LE>",
                                writeBigInt64BE: "Function<writeBigInt64BE>",
                                readUIntLE: "Function<readUIntLE>",
                                readUInt32LE: "Function<readUInt32LE>",
                                readUInt16LE: "Function<readUInt16LE>",
                                readUInt8: "Function<readUInt8>",
                                readUIntBE: "Function<readUIntBE>",
                                readUInt32BE: "Function<readUInt32BE>",
                                readUInt16BE: "Function<readUInt16BE>",
                                readUintLE: "Function<readUIntLE>",
                                readUint32LE: "Function<readUInt32LE>",
                                readUint16LE: "Function<readUInt16LE>",
                                readUint8: "Function<readUInt8>",
                                readUintBE: "Function<readUIntBE>",
                                readUint32BE: "Function<readUInt32BE>",
                                readUint16BE: "Function<readUInt16BE>",
                                readIntLE: "Function<readIntLE>",
                                readInt32LE: "Function<readInt32LE>",
                                readInt16LE: "Function<readInt16LE>",
                                readInt8: "Function<readInt8>",
                                readIntBE: "Function<readIntBE>",
                                readInt32BE: "Function<readInt32BE>",
                                readInt16BE: "Function<readInt16BE>",
                                writeUIntLE: "Function<writeUIntLE>",
                                writeUInt32LE: "Function<writeUInt32LE>",
                                writeUInt16LE: "Function<writeUInt16LE>",
                                writeUInt8: "Function<writeUInt8>",
                                writeUIntBE: "Function<writeUIntBE>",
                                writeUInt32BE: "Function<writeUInt32BE>",
                                writeUInt16BE: "Function<writeUInt16BE>",
                                writeUintLE: "Function<writeUIntLE>",
                                writeUint32LE: "Function<writeUInt32LE>",
                                writeUint16LE: "Function<writeUInt16LE>",
                                writeUint8: "Function<writeUInt8>",
                                writeUintBE: "Function<writeUIntBE>",
                                writeUint32BE: "Function<writeUInt32BE>",
                                writeUint16BE: "Function<writeUInt16BE>",
                                writeIntLE: "Function<writeIntLE>",
                                writeInt32LE: "Function<writeInt32LE>",
                                writeInt16LE: "Function<writeInt16LE>",
                                writeInt8: "Function<writeInt8>",
                                writeIntBE: "Function<writeIntBE>",
                                writeInt32BE: "Function<writeInt32BE>",
                                writeInt16BE: "Function<writeInt16BE>",
                                readFloatLE: "Function<readFloatForwards>",
                                readFloatBE: "Function<readFloatBackwards>",
                                readDoubleLE: "Function<readDoubleForwards>",
                                readDoubleBE: "Function<readDoubleBackwards>",
                                writeFloatLE: "Function<writeFloatForwards>",
                                writeFloatBE: "Function<writeFloatBackwards>",
                                writeDoubleLE: "Function<writeDoubleForwards>",
                                writeDoubleBE: "Function<writeDoubleBackwards>",
                                asciiSlice: "Function<asciiSlice>",
                                base64Slice: "Function<base64Slice>",
                                base64urlSlice: "Function<base64urlSlice>",
                                latin1Slice: "Function<latin1Slice>",
                                hexSlice: "Function<hexSlice>",
                                ucs2Slice: "Function<ucs2Slice>",
                                utf8Slice: "Function<utf8Slice>",
                                asciiWrite: "Function<asciiWrite>",
                                base64Write: "Function<base64Write>",
                                base64urlWrite: "Function<base64urlWrite>",
                                latin1Write: "Function<latin1Write>",
                                hexWrite: "Function<hexWrite>",
                                ucs2Write: "Function<ucs2Write>",
                                utf8Write: "Function<utf8Write>",
                                parent: {
                                  constructor: "Function<ArrayBuffer>",
                                  byteLength: 8192,
                                  slice: "Function<slice>",
                                  maxByteLength: 8192,
                                  resizable: false,
                                  resize: "Function<resize>",
                                },
                                offset: 5730,
                                copy: "Function<copy>",
                                toString: "Function<toString>",
                                equals: "Function<equals>",
                                inspect: "Function<inspect>",
                                compare: "Function<compare>",
                                indexOf: "Function<indexOf>",
                                lastIndexOf: "Function<lastIndexOf>",
                                includes: "Function<includes>",
                                fill: "Function<fill>",
                                write: "Function<write>",
                                toJSON: "Function<toJSON>",
                                subarray: "Function<subarray>",
                                slice: "Function<slice>",
                                swap16: "Function<swap16>",
                                swap32: "Function<swap32>",
                                swap64: "Function<swap64>",
                                toLocaleString: "Function<toString>",
                                BYTES_PER_ELEMENT: 1,
                                buffer: {
                                  constructor: "Function<ArrayBuffer>",
                                  byteLength: 8192,
                                  slice: "Function<slice>",
                                  maxByteLength: 8192,
                                  resizable: false,
                                  resize: "Function<resize>",
                                },
                                byteLength: 12,
                                byteOffset: 5730,
                                length: 12,
                                entries: "Function<entries>",
                                keys: "Function<keys>",
                                values: "Function<values>",
                                at: "Function<at>",
                                copyWithin: "Function<copyWithin>",
                                every: "Function<every>",
                                filter: "Function<filter>",
                                find: "Function<find>",
                                findIndex: "Function<findIndex>",
                                findLast: "Function<findLast>",
                                findLastIndex: "Function<findLastIndex>",
                                forEach: "Function<forEach>",
                                join: "Function<join>",
                                map: "Function<map>",
                                reverse: "Function<reverse>",
                                reduce: "Function<reduce>",
                                reduceRight: "Function<reduceRight>",
                                set: "Function<set>",
                                some: "Function<some>",
                                sort: "Function<sort>",
                                toReversed: "Function<toReversed>",
                                toSorted: "Function<toSorted>",
                                with: "Function<with>",
                              },
                              position: 12,
                              constructor: "Function<Binary>",
                              _bsontype: "Binary",
                              put: "Function<put>",
                              write: "Function<write>",
                              read: "Function<read>",
                              value: "Function<value>",
                              length: "Function<length>",
                              toJSON: "Function<toJSON>",
                              toString: "Function<toString>",
                              toExtendedJSON: "Function<toExtendedJSON>",
                              toUUID: "Function<toUUID>",
                              inspect: "Function<inspect>",
                            },
                          },
                          consideredType: "object",
                        },
                      ],
                    },
                  ],
                },
              ],
            },
          },
          op: {
            _id: {
              buffer: {
                "0": 100,
                "1": 49,
                "2": 227,
                "3": 224,
                "4": 180,
                "5": 126,
                "6": 3,
                "7": 141,
                "8": 93,
                "9": 18,
                "10": 253,
                "11": 242,
                constructor: "Function<Uint8Array>",
                BYTES_PER_ELEMENT: 1,
                buffer: {
                  constructor: "Function<ArrayBuffer>",
                  byteLength: 8192,
                  slice: "Function<slice>",
                  maxByteLength: 8192,
                  resizable: false,
                  resize: "Function<resize>",
                },
                byteLength: 12,
                byteOffset: 7416,
                length: 12,
                entries: "Function<entries>",
                keys: "Function<keys>",
                values: "Function<values>",
                at: "Function<at>",
                copyWithin: "Function<copyWithin>",
                every: "Function<every>",
                fill: "Function<fill>",
                filter: "Function<filter>",
                find: "Function<find>",
                findIndex: "Function<findIndex>",
                findLast: "Function<findLast>",
                findLastIndex: "Function<findLastIndex>",
                forEach: "Function<forEach>",
                includes: "Function<includes>",
                indexOf: "Function<indexOf>",
                join: "Function<join>",
                lastIndexOf: "Function<lastIndexOf>",
                map: "Function<map>",
                reverse: "Function<reverse>",
                reduce: "Function<reduce>",
                reduceRight: "Function<reduceRight>",
                set: "Function<set>",
                slice: "Function<slice>",
                some: "Function<some>",
                sort: "Function<sort>",
                subarray: "Function<subarray>",
                toLocaleString: "Function<toLocaleString>",
                toString: "Function<toString>",
                toReversed: "Function<toReversed>",
                toSorted: "Function<toSorted>",
                with: "Function<with>",
              },
            },
            source: "Kit apprentissage et RNCP v1.0.csv",
            date: {
              constructor: "Function<Date>",
              toString: "Function<toString>",
              toDateString: "Function<toDateString>",
              toTimeString: "Function<toTimeString>",
              toISOString: "Function<toISOString>",
              toUTCString: "Function<toUTCString>",
              toGMTString: "Function<toUTCString>",
              getDate: "Function<getDate>",
              setDate: "Function<setDate>",
              getDay: "Function<getDay>",
              getFullYear: "Function<getFullYear>",
              setFullYear: "Function<setFullYear>",
              getHours: "Function<getHours>",
              setHours: "Function<setHours>",
              getMilliseconds: "Function<getMilliseconds>",
              setMilliseconds: "Function<setMilliseconds>",
              getMinutes: "Function<getMinutes>",
              setMinutes: "Function<setMinutes>",
              getMonth: "Function<getMonth>",
              setMonth: "Function<setMonth>",
              getSeconds: "Function<getSeconds>",
              setSeconds: "Function<setSeconds>",
              getTime: "Function<getTime>",
              setTime: "Function<setTime>",
              getTimezoneOffset: "Function<getTimezoneOffset>",
              getUTCDate: "Function<getUTCDate>",
              setUTCDate: "Function<setUTCDate>",
              getUTCDay: "Function<getUTCDay>",
              getUTCFullYear: "Function<getUTCFullYear>",
              setUTCFullYear: "Function<setUTCFullYear>",
              getUTCHours: "Function<getUTCHours>",
              setUTCHours: "Function<setUTCHours>",
              getUTCMilliseconds: "Function<getUTCMilliseconds>",
              setUTCMilliseconds: "Function<setUTCMilliseconds>",
              getUTCMinutes: "Function<getUTCMinutes>",
              setUTCMinutes: "Function<setUTCMinutes>",
              getUTCMonth: "Function<getUTCMonth>",
              setUTCMonth: "Function<setUTCMonth>",
              getUTCSeconds: "Function<getUTCSeconds>",
              setUTCSeconds: "Function<setUTCSeconds>",
              valueOf: "Function<valueOf>",
              getYear: "Function<getYear>",
              setYear: "Function<setYear>",
              toJSON: "Function<toJSON>",
              toLocaleString: "Function<toLocaleString>",
              toLocaleDateString: "Function<toLocaleDateString>",
              toLocaleTimeString: "Function<toLocaleTimeString>",
            },
            data: {
              "Code Diplôme": "17021006",
              "Intitulé diplôme (DEPP)":
                "INGENIEUR DIPLOME DE L'INSTITUT SUPERIEUR D'AGRICULTURE RHONE-ALPES",
              FicheRNCP: "RNCP1997",
              "Niveau fiche RNCP": "niveau7",
              "Abrégé de diplôme (RNCP)": "ING",
              "Dernière MaJ": "v1.0",
              "Accès à l'apprentissage de la fiche RNCP (oui/non)": null,
              "Date d'échéance de la fiche RNCP": null,
              "Fiche ACTIVE/INACTIVE": null,
              "Intitulé certification (RNCP)": null,
              "Type d'enregistrement": null,
              "Date de publication de la fiche": null,
              "Date de décision": null,
              "Date de début des parcours certifiants": null,
              "Date limite de la délivrance": null,
              "Nouvelle Certification rempla (RNCP)": null,
              "Ancienne Certification (RNCP)": null,
            },
            version: "20200414",
          },
        },
        constructor: "Function<WriteError>",
        code: 121,
        index: +0,
        errmsg: "Document failed validation",
        errInfo: {
          failingDocumentId: {
            buffer: {
              sub_type: +0,
              buffer: {
                "0": 100,
                "1": 49,
                "2": 227,
                "3": 224,
                "4": 180,
                "5": 126,
                "6": 3,
                "7": 141,
                "8": 93,
                "9": 18,
                "10": 253,

Suggested solution

Being able to customize serialized value of error (here I'd use ObjectId.toString) and strip function names.

Or it could be an option to use toJSON when the function is defined in the object.

Alternative

No response

Additional context

No response

Validations
@hi-ogawa
Copy link
Contributor

hi-ogawa commented Apr 4, 2024 •
edited

I have issue with the default serialized error,

Just in case, could you explain what exactly the "issue" is instead of suggesting the "solution" which is supposed to solve that unclarified "issue"?

Would it be essentially same as this issue where Vitest's last Serialized Error: occupies terminal too much?

To understand your request better, we'll need more context and ideally reproductions to illustrate the issue.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024

Hello @moroine. Please provide a minimal reproduction using a GitHub repository or StackBlitz (you can also use examples). Issues marked with needs reproduction will be closed if they have no activity within 3 days.

@moroine
Copy link
Author

moroine commented Apr 5, 2024

Just in case, could you explain what exactly the "issue" is instead of suggesting the "solution" which is supposed to solve that unclarified "issue"?

My bad sorry, the problem I'd like to fix is the output is not readable. There is a lot of pollution in the output

About the solution proposed, it's mostly because it was requested in the template. An in order to have generic output, we could use toJSON to serialize when it's explicitly defined or simply allow to pass custom serialization function.

Would it be essentially same as this issue where Vitest's last Serialized Error: occupies terminal too much?

It's not really this issue, I'd like to see all data within the error and keep the same verbosity. The main goal is how to format this data (especially with buffer and function fields).

To understand your request better, we'll need more context and ideally reproductions to illustrate the issue.

I've created a reproduction, and you can see in the console for exemple the ObjectId serialisation https://stackblitz.com/edit/vitest-dev-vitest-wexjnr?file=test%2Fsuite.test.ts.

@hi-ogawa
Copy link
Contributor

hi-ogawa commented Apr 5, 2024

Thanks for the repro. Yeah, I can understand the issue better now. Previously I wasn't even sure if you were talking about Serialized Error: ... output.

Test errors need to be passed from test runner runtime to main process and it requires some serializations:

vitest/packages/utils/src/error.ts

Lines 29 to 33 in 9dee912

export function serializeError(val: any, seen = new WeakMap()): any {
if (!val || typeof val === 'string')
return val
if (typeof val === 'function')
return `Function<${val.name || 'anonymous'}>`

Currently there's no customization possible here, but maybe somehow we can allow users to intercept and customize it.

@sheremet-va sheremet-va added p3-minor-bug An edge case that only affects very specific usage (priority) and removed enhancement: pending triage labels Apr 11, 2024
@hi-ogawa
Copy link
Contributor

I was playing with the reproduction and I found that it already gets weird with Date. Calling Date.toJSON should also fix this.
https://stackblitz.com/edit/vitest-dev-vitest-cxupqb?file=test%2Fsuite.test.ts

 FAIL  test/suite.test.ts > repro
Error: Failed
 ❯ eval test/suite.test.ts:4:15
      2| 
      3| it('repro', () => {
      4|   const err = new Error('Failed');
       |               ^
      5|   err.date = new Date()
      6|   throw err;

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: { date: { constructor: 'Function<Date>', toString: 'Function<toString>', toDateString: 'Function<toDateString>', toTimeString: 'Function<toTimeString>', toISOString: 'Function<toISOString>', toUTCString: 'Function<toUTCString>', toGMTString: 'Function<toUTCString>', getDate: 'Function<getDate>', setDate: 'Function<setDate>', getDay: 'Function<getDay>', getFullYear: 'Function<getFullYear>', setFullYear: 'Function<setFullYear>', getHours: 'Function<getHours>', setHours: 'Function<setHours>', getMilliseconds: 'Function<getMilliseconds>', setMilliseconds: 'Function<setMilliseconds>', getMinutes: 'Function<getMinutes>', setMinutes: 'Function<setMinutes>', getMonth: 'Function<getMonth>', setMonth: 'Function<setMonth>', getSeconds: 'Function<getSeconds>', setSeconds: 'Function<setSeconds>', getTime: 'Function<getTime>', setTime: 'Function<setTime>', getTimezoneOffset: 'Function<getTimezoneOffset>', getUTCDate: 'Function<getUTCDate>', setUTCDate: 'Function<setUTCDate>', getUTCDay: 'Function<getUTCDay>', getUTCFullYear: 'Function<getUTCFullYear>', setUTCFullYear: 'Function<setUTCFullYear>', getUTCHours: 'Function<getUTCHours>', setUTCHours: 'Function<setUTCHours>', getUTCMilliseconds: 'Function<getUTCMilliseconds>', setUTCMilliseconds: 'Function<setUTCMilliseconds>', getUTCMinutes: 'Function<getUTCMinutes>', setUTCMinutes: 'Function<setUTCMinutes>', getUTCMonth: 'Function<getUTCMonth>', setUTCMonth: 'Function<setUTCMonth>', getUTCSeconds: 'Function<getUTCSeconds>', setUTCSeconds: 'Function<setUTCSeconds>', valueOf: 'Function<valueOf>', getYear: 'Function<getYear>', setYear: 'Function<setYear>', toJSON: 'Function<toJSON>', toLocaleString: 'Function<toLocaleString>', toLocaleDateString: 'Function<toLocaleDateString>', toLocaleTimeString: 'Function<toLocaleTimeString>' } }
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/1]⎯

@hi-ogawa hi-ogawa mentioned this issue Apr 12, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
Team Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use toJSON for error serialization hi-ogawa/vitest
3 participants
@hi-ogawa @moroine @sheremet-va