Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.26] Mocking default cyclic dependencies hangs #2567

Closed
6 tasks done
danez opened this issue Dec 26, 2022 · 1 comment · Fixed by #2572
Closed
6 tasks done

[0.26] Mocking default cyclic dependencies hangs #2567

danez opened this issue Dec 26, 2022 · 1 comment · Fixed by #2572

Comments

@danez
Copy link
Contributor

danez commented Dec 26, 2022

Describe the bug

Since version 0.26 mocking default exports of a cyclic dependency starts hanging the tests suite without any output (Github Actions times out after 6h, see this PR)

I already created a test for this and tried to debug this, but wasn't successful by now. I can still look further into this, but probably not before january. So I thought I might report it already in case you have an idea about the problem.

I tried with #2560 but that did no change anything.

Happy holidays and thanks for this great tool. 🎉💜🌴

Reproduction

Either:
045eb57

Or:

https://github.com/danez-labs/vitest-default-commonjs

npm i
npm test

System Info

System:
    OS: macOS 13.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 4.34 GB / 32.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 18.12.1 - ~/.asdf/installs/nodejs/lts/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 8.19.2 - ~/.asdf/plugins/nodejs/shims/npm
  Browsers:
    Safari: 16.2
  npmPackages:
    vite: 4.0.3 => 4.0.3 
    vitest: 0.26.2 => 0.26.2

Used Package Manager

pnpm

Validations

@sheremet-va
Copy link
Member

Thank you for the bug report. Indeed, there was an issue after the rewrite, #2572 should fix this 👍🏻

@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants