feat: add --shard command #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
antfu
reviewed
Jun 14, 2022
packages/vitest/src/node/config.ts
Outdated
| ), | ||
| ) | ||
|
|
||
| process.exit(1) |
There was a problem hiding this comment.
Better to just throw the error, as resolveConfig can be used programmatically, and the caller might want to catch the error.
There was a problem hiding this comment.
We have a bug, when throwing an error, process doesn't stop 👀
There was a problem hiding this comment.
We can catch it and process.exit in the caller, instead of having side-effect for resolveConfig
There was a problem hiding this comment.
I've added throwing, but I still do process.exit when catching the error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1464