Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make exports prop of proxy point to exports object #1260

Merged
merged 1 commit into from May 9, 2022

Conversation

nieyuyao
Copy link
Contributor

@nieyuyao nieyuyao commented May 8, 2022

fix #1218

@netlify
Copy link

netlify bot commented May 8, 2022

Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 2ee745b
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/62790deccd0a7700098ac7ce
😎 Deploy Preview https://deploy-preview-1260--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sheremet-va
Copy link
Member

Please, can you add a test for this?

@nieyuyao nieyuyao changed the title fix: add default prop to exports #1218 fix: add default prop to exports May 8, 2022
@nieyuyao nieyuyao changed the title fix: add default prop to exports wip: fix: add default prop to exports May 8, 2022
@nieyuyao nieyuyao changed the title wip: fix: add default prop to exports wip: fix: make exports prop of proxy point to exports object May 8, 2022
@nieyuyao nieyuyao changed the title wip: fix: make exports prop of proxy point to exports object fix: make exports prop of proxy point to exports object May 8, 2022
@sheremet-va sheremet-va requested a review from antfu May 8, 2022 10:00
@antfu antfu merged commit cd4bed5 into vitest-dev:main May 9, 2022
@nieyuyao nieyuyao deleted the fix/module-exports branch May 10, 2022 09:50
chaii3 pushed a commit to chaii3/vitest that referenced this pull request May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vitest throws error when importing a file with module.exports.property = ...
3 participants