refactor(vite-node): Replace minimist with cac #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
antoinerey
commented
May 6, 2022
packages/vite-node/src/cli.ts
Outdated
Comment on lines
29
to
30
| // silent?: boolean | ||
| // vue?: boolean |
There was a problem hiding this comment.
Are those two options still necessary? I could not find any reference to them. Were they forgotten in a previous refactor?
antoinerey
force-pushed
the
refactor/switch-vite-node-from-minimist-to-cac
branch
from
a9f58f4
to
a15cefc
Compare
antoinerey
force-pushed
the
refactor/switch-vite-node-from-minimist-to-cac
branch
from
c02af23
to
8683de6
Compare
sheremet-va
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1215, let's replace minimist with cac to allow further changes.
Note that
--silentand--vueflags have been removed from the CLI. They were displayed in the help, but were not used in any way.