feat: remove shebang when executing the code via vite-node #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
sheremet-va
requested changes
May 1, 2022
7 tasks
|
The PR for vite is merged!! I'll rebase main branch after the next vite release and update this PR. |
|
Thanks for the PR in vite @togami2864! vite@2.9.8 has been released with it. |
togami2864
force-pushed
the
feat/remove-shebang
branch
from
e0210a4
to
0e2c402
Compare
sheremet-va
requested changes
May 6, 2022
antfu
reviewed
May 6, 2022
packages/vite-node/src/client.ts
Outdated
| @@ -178,7 +178,7 @@ export class ViteNodeRunner { | |||
| }) | |||
|
|
|||
| // add 'use strict' since ESM enables it by default | |||
| const fn = vm.runInThisContext(`'use strict';async (${Object.keys(context).join(',')})=>{{${transformed}\n}}`, { | |||
| const fn = vm.runInThisContext(`'use strict';async (${Object.keys(context).join(',')})=>{{${transformed.replace(/^\#\!.*/, '')}\n}}`, { | |||
There was a problem hiding this comment.
Suggested change
| const fn = vm.runInThisContext(`'use strict';async (${Object.keys(context).join(',')})=>{{${transformed.replace(/^\#\!.*/, '')}\n}}`, { | |
| const fn = vm.runInThisContext(`'use strict';async (${Object.keys(context).join(',')})=>{{${transformed.replace(/^\#\!.*/, s => ' '.repeat(s.length))}\n}}`, { |
To avoid index changes.
sheremet-va
approved these changes
May 6, 2022
antfu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1175