Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: self exported module call stack error #1221

Merged
merged 2 commits into from May 1, 2022

Conversation

pikax
Copy link
Contributor

@pikax pikax commented May 1, 2022

fix #1220

exporting itself is wrong, but it can be exported by mistake, vite handles the export just fine.

note: eslint was crashing :D so I ignored the files for this specific test

@netlify
Copy link

netlify bot commented May 1, 2022

Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 5bfa7b8
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/626eb4f5b43f7d00081a2d66
😎 Deploy Preview https://deploy-preview-1221--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

packages/vite-node/src/client.ts Outdated Show resolved Hide resolved
@sheremet-va sheremet-va enabled auto-merge (squash) May 1, 2022 16:32
@sheremet-va sheremet-va merged commit 4956713 into vitest-dev:main May 1, 2022
@pikax pikax deleted the fix_self_referencing_module branch May 1, 2022 18:40
chaii3 pushed a commit to chaii3/vitest that referenced this pull request May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maximum call stack when export the current file
2 participants