Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve id before loading from vite #1204

Merged

Conversation

sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Apr 28, 2022

Previously we were only processing imports inside already transformed file. This PR tries to fix path, when ViteNode is called directly (with executeId or executeFile)

Fixes #1194
Fixes #1195

@netlify
Copy link

netlify bot commented Apr 28, 2022

Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 5f8b525
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/62737cc6c36b9a000806e8b1
😎 Deploy Preview https://deploy-preview-1204--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sheremet-va sheremet-va marked this pull request as draft April 28, 2022 13:23
@sheremet-va sheremet-va marked this pull request as ready for review May 3, 2022 06:20
@sheremet-va sheremet-va requested a review from antfu May 3, 2022 06:29
@antfu antfu added this to the Next milestone May 3, 2022
@sheremet-va
Copy link
Member Author

For some reason some changes here stall the terminal. Will try to figure it out, when I have the time.

@sheremet-va sheremet-va marked this pull request as draft May 3, 2022 08:18
@sheremet-va sheremet-va marked this pull request as ready for review May 5, 2022 07:16
@antfu antfu merged commit 110788a into vitest-dev:main May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants