From 58818f2d9a531dfe42ccf730812d669df18583f5 Mon Sep 17 00:00:00 2001 From: Vladimir Sheremet Date: Tue, 14 Jun 2022 20:55:18 +0300 Subject: [PATCH] fix: parent is defined on global, closes #1489 --- packages/vitest/src/integrations/env/utils.ts | 1 + test/core/test/dom.test.ts | 3 +++ test/core/test/happy-dom.test.ts | 2 ++ 3 files changed, 6 insertions(+) diff --git a/packages/vitest/src/integrations/env/utils.ts b/packages/vitest/src/integrations/env/utils.ts index c412ebcef09b..851d06cea255 100644 --- a/packages/vitest/src/integrations/env/utils.ts +++ b/packages/vitest/src/integrations/env/utils.ts @@ -71,6 +71,7 @@ export function populateGlobal(global: any, win: any, options: PopulateOptions = global.window = global global.self = global global.top = global + global.parent = global if (global.global) global.global = global diff --git a/test/core/test/dom.test.ts b/test/core/test/dom.test.ts index 1756a5065fe4..85ccd0b6fe72 100644 --- a/test/core/test/dom.test.ts +++ b/test/core/test/dom.test.ts @@ -13,6 +13,9 @@ declare global { it('jsdom', () => { expect(window).toBeDefined() + expect(top).toBeDefined() + expect(parent).toBeDefined() + expect(self).toBeDefined() const dom = document.createElement('a') dom.href = 'https://vitest.dev' diff --git a/test/core/test/happy-dom.test.ts b/test/core/test/happy-dom.test.ts index 772b2d06042f..5dbb079a6fda 100644 --- a/test/core/test/happy-dom.test.ts +++ b/test/core/test/happy-dom.test.ts @@ -14,6 +14,8 @@ declare global { it('defined on self/window are defined on global', () => { expect(self).toBeDefined() expect(window).toBeDefined() + expect(top).toBeDefined() + expect(parent).toBeDefined() expect(self.__property_dom).not.toBeDefined() expect(window.__property_dom).not.toBeDefined()