Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSX transform import bug in production #1352

Closed
keller-mark opened this issue Dec 2, 2022 · 0 comments · Fixed by #1351
Closed

JSX transform import bug in production #1352

keller-mark opened this issue Dec 2, 2022 · 0 comments · Fixed by #1351
Labels
bug Something isn't working

Comments

@keller-mark
Copy link
Member

keller-mark commented Dec 2, 2022

Describe the bug

When testing out hubmapconsortium/portal-ui#2991 it seems that the production bundle works until clicking the three-dot icon in the cell set manager, when Vitessce crashes with the following error.

The error does not occur when the dependency and import statements are switched from vitessce (the production bundle) to @vitessce/dev (the development bundle).

It seems related to the JSX transform in Vite production vs development modes:

To Reproduce
Steps to reproduce the behavior:

Uncaught TypeError: Rs.exports.jsxDEV is not a function

Screen Shot 2022-12-02 at 1 11 42 PM

In contrast, when using @vitessce/dev v2.0.1, we see the expected behavior:

Screen Shot 2022-12-02 at 1 08 25 PM

Simpler reproducer

https://observablehq.com/@keller-mark/vitessce-from-unpkg change vitessce to @vitessce/dev in the require statement

Environment:

  • Release or git hash: 2.0.1
  • Browser: firefox
@keller-mark keller-mark added the bug Something isn't working label Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant