Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What uses aiofiles? #130

Closed
mccalluc opened this issue Apr 5, 2022 · 1 comment · Fixed by #135
Closed

What uses aiofiles? #130

mccalluc opened this issue Apr 5, 2022 · 1 comment · Fixed by #135

Comments

@mccalluc
Copy link
Contributor

mccalluc commented Apr 5, 2022

It's included in setup.py, but searching the code base doesn't reveal any other places where it's used. git blame to see when it was introduction, and what might depend on it.

@mccalluc
Copy link
Contributor Author

mccalluc commented Apr 5, 2022

starlette uses aiofiles, but doesn't list it as an explicit dependency. 🤷

It looks like in the current version it's no longer necessary, and has been replaced by anyio... so I'd suggest upgrading, and if that doesn't work, add a note in the dependencies list explaining why it's here.

(I'm worrying about this now because I'm trying to identify which are the core dependencies needed just for configuration generation.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant