From b718f95ebef411488808a0c646f2e1ec122384f3 Mon Sep 17 00:00:00 2001 From: hoanguyen Date: Tue, 9 Aug 2022 14:23:45 +0700 Subject: [PATCH 1/2] fix(ssr-manifest): check name before saving to ssrManifest --- packages/vite/src/node/ssr/ssrManifestPlugin.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/vite/src/node/ssr/ssrManifestPlugin.ts b/packages/vite/src/node/ssr/ssrManifestPlugin.ts index 993fae1632ed5d..de4c55e66058bd 100644 --- a/packages/vite/src/node/ssr/ssrManifestPlugin.ts +++ b/packages/vite/src/node/ssr/ssrManifestPlugin.ts @@ -68,7 +68,9 @@ export function ssrManifestPlugin(config: ResolvedConfig): Plugin { join(dirname(chunk.fileName), url.slice(1, -1)) ) addDeps(normalizedFile) - ssrManifest[basename(name!)] = deps + if (name) { + ssrManifest[basename(name!)] = deps + } } } } From 5b3f49310e549544d6086e95413f3054c989010d Mon Sep 17 00:00:00 2001 From: hoanguyen Date: Thu, 11 Aug 2022 10:07:38 +0700 Subject: [PATCH 2/2] fix(ssr-manifest): filter path undefined when dynamic import --- packages/vite/src/node/ssr/ssrManifestPlugin.ts | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/packages/vite/src/node/ssr/ssrManifestPlugin.ts b/packages/vite/src/node/ssr/ssrManifestPlugin.ts index de4c55e66058bd..476a5c304c4950 100644 --- a/packages/vite/src/node/ssr/ssrManifestPlugin.ts +++ b/packages/vite/src/node/ssr/ssrManifestPlugin.ts @@ -39,7 +39,7 @@ export function ssrManifestPlugin(config: ResolvedConfig): Plugin { const code = chunk.code let imports: ImportSpecifier[] try { - imports = parseImports(code)[0].filter((i) => i.d > -1) + imports = parseImports(code)[0].filter((i) => i.n && i.d > -1) } catch (e: any) { this.error(e, e.idx) } @@ -68,9 +68,7 @@ export function ssrManifestPlugin(config: ResolvedConfig): Plugin { join(dirname(chunk.fileName), url.slice(1, -1)) ) addDeps(normalizedFile) - if (name) { - ssrManifest[basename(name!)] = deps - } + ssrManifest[basename(name!)] = deps } } }