From 259f91f3b6914f53d958e16db7dd63332fc67084 Mon Sep 17 00:00:00 2001 From: patak-dev Date: Fri, 15 Jul 2022 23:09:30 +0200 Subject: [PATCH] fix: ssr.external/noExternal should apply to packageName --- packages/vite/src/node/ssr/ssrExternal.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/vite/src/node/ssr/ssrExternal.ts b/packages/vite/src/node/ssr/ssrExternal.ts index c69c117ebde843..6c21c06ca8833b 100644 --- a/packages/vite/src/node/ssr/ssrExternal.ts +++ b/packages/vite/src/node/ssr/ssrExternal.ts @@ -120,13 +120,17 @@ export function createIsConfiguredAsSsrExternal( return (id: string) => { const { ssr } = config if (ssr) { - if (ssr.external?.includes(id)) { + const pkgName = getNpmPackageName(id) + if (!pkgName) { + return undefined + } + if (ssr.external?.includes(pkgName)) { return true } if (typeof noExternal === 'boolean') { return !noExternal } - if (noExternalFilter && !noExternalFilter(id)) { + if (noExternalFilter && !noExternalFilter(pkgName)) { return false } }