fix(plugin-react): wrong substitution causes React is not defined
#9386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
p2-edge-case
9 tasks
aleclarson
reviewed
Jul 29, 2022
Comment on lines
-57
to
-59
| // Assume `Fragment` is equivalent to `React.Fragment` so modules | ||
| // that use `import {Fragment} from 'react'` are reverse compiled. | ||
| (component === 'Fragment' ? 'React.Fragment' : component) |
There was a problem hiding this comment.
This PR is missing special handling for import { Fragment } from 'react' usage.
There was a problem hiding this comment.
Looks like it was handled 79ff627
Yes, updated. |
aleclarson
approved these changes
Aug 3, 2022
|
@aleclarson do you think this should be in a patch or in a minor for plugin-react? |
|
@patak-dev Patch, since this fixes intended behavior |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: #9371
I don't think it's necessary to replace
reactAlias.createElement/FragmentwithReact.createElement/Fragmentbefore transform to jsx, which results in a lot of edge cases.We can just use
reactAliasto determine if we can transform to jsx, which will also become faster!Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).