Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update browser baseline features #9316

Merged
merged 1 commit into from Jul 23, 2022
Merged

docs: update browser baseline features #9316

merged 1 commit into from Jul 23, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jul 23, 2022

Description

Consistently show that import.meta is a required baseline for browser support.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the documentation Improvements or additions to documentation label Jul 23, 2022
bluwy
bluwy commented Jul 23, 2022
View reviewed changes
packages/vite/src/node/constants.ts
// "defaults and supports es6-module and supports es6-module-dynamic-import",
// Baseline support browserslist
// "defaults and supports es6-module and supports es6-module-dynamic-import"
// Higher browser versions may be needed for extra features.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Browserlist can't query import.meta support so thought I'd add this here. Also because we don't follow this browserlist strictly, as we bump base on usage.

@patak-dev patak-dev merged commit b82ee5d into main Jul 23, 2022
@patak-dev patak-dev deleted the docs-browser-baseline branch July 23, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bluwy @patak-dev