Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[astro ci] Cannot read property 'isSelfAccepting' of undefined #9252

Closed
7 tasks done
bholmesdev opened this issue Jul 20, 2022 · 1 comment · Fixed by #9262
Closed
7 tasks done

[astro ci] Cannot read property 'isSelfAccepting' of undefined #9252

bholmesdev opened this issue Jul 20, 2022 · 1 comment · Fixed by #9262

Comments

@bholmesdev
Copy link
Contributor

Describe the bug

Astro discovered a failure in our test runner on the latest Vite branch. This error does not exist on the current Vite npm release. We're unable to find a minimal reproduction, but it can be reproduced by cloning both Astro and Vite locally.

Note: we have seen this error before! This was previously resolved by fixing a race condition found here: #8533

Reproduction

(see steps)

System Info

System:
    OS: macOS 12.2
    CPU: (8) x64 Apple M1 Pro
    Memory: 21.53 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 14.18.1 - ~/.volta/tools/image/node/14.18.1/bin/node
    Yarn: 1.22.17 - ~/.volta/tools/image/yarn/1.22.17/bin/yarn
    npm: 8.4.0 - ~/.volta/tools/image/npm/8.4.0/bin/npm
  Browsers:
    Chrome: 103.0.5060.114
    Firefox: 102.0.1
    Safari: 15.3

Used Package Manager

pnpm

Logs

  1. Run pnpm build and pnpm link --global from ~/repos/vite/packages/vite
  2. Run pnpm link --global vite from ~/repos/astro/packages/astro
  3. Run pnpm dev (or build) from ~/repos/astro
  4. Run a known failing test, like pnpm test:match "<Code> without lang or theme"
  5. Hit the following error:
Error log
TypeError: Cannot read property 'isSelfAccepting' of undefined
      at Object.transform (file:///Users/benholmes/Repositories/vite/packages/vite/dist/node/chunks/dep-b5e99e9a.js:40409:43)
      at async transform (file:///Users/benholmes/Repositories/vite/node_modules/.pnpm/rollup@2.75.6/node_modules/rollup/dist/es/shared/rollup.js:21952:16)
      at async ModuleLoader.addModuleSource (file:///Users/benholmes/Repositories/vite/node_modules/.pnpm/rollup@2.75.6/node_modules/rollup/dist/es/shared/rollup.js:22178:30)

Validations

@sapphi-red
Copy link
Member

I ran ecosystem-ci several times and found that it started to happen from 3e510ab.

This was referenced Jul 21, 2022
@sapphi-red sapphi-red linked a pull request Jul 21, 2022 that will close this issue
9 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants