fix: ssr.external/noExternal should apply to packageName #9146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patak-dev
added
the
p4-important
✅ Deploy Preview for vite-docs-main canceled.
|
|
cc @benmccann @dominikg @bluwy We should check vite-ecosystem-ci and merge this PR, so it is included in Monday's release |
dominikg
reviewed
Jul 15, 2022
| @@ -120,13 +120,17 @@ export function createIsConfiguredAsSsrExternal( | |||
| return (id: string) => { | |||
| const { ssr } = config | |||
| if (ssr) { | |||
| if (ssr.external?.includes(id)) { | |||
| const pkgName = getNpmPackageName(id) | |||
There was a problem hiding this comment.
getNpmPackageName returns '' for id='/some/path/with/leading/slash' which is falsy and returns undefined then. This is what we want, right?
There was a problem hiding this comment.
Only bare imports reach this check, so this is not possible 👍🏼
|
vite-ecosystem-ci run for this PR https://github.com/vitejs/vite-ecosystem-ci/actions/runs/2679454666, that is all green for prev working CIs |
dominikg
approved these changes
Jul 15, 2022
|
Merging as this is an important fix for downstream |
This was referenced Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes
Also fixes https://github.com/Cluster2a/chartjsError, where we need now to add because of deps being external by default:
What is the purpose of this pull request?