Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly replace import.meta.url in config #7792

Merged
merged 1 commit into from Apr 18, 2022

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Apr 18, 2022

Description

file://${args.path} was used to construct file url in packages/vite/src/node/config.ts.
But url.pathToFileURL(path) should be used for this.
Not sure if there is any actual bug with this but I think it potentially leads to a bug.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would now encode the url path, but it's more correct as I've also confirmed that import.meta.url returns an encoded path in nodejs esm.

@bluwy bluwy added the p3-minor-bug An edge case that only affects very specific usage (priority) label Apr 18, 2022
@patak-dev patak-dev merged commit 12d1194 into vitejs:main Apr 18, 2022
@sapphi-red sapphi-red deleted the fix/import-meta-url-in-config branch April 19, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants