Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review experimental options for Vite 3 #7653

Closed
4 tasks done
bluwy opened this issue Apr 8, 2022 · 2 comments · Fixed by #7707
Closed
4 tasks done

Review experimental options for Vite 3 #7653

bluwy opened this issue Apr 8, 2022 · 2 comments · Fixed by #7707
Labels
enhancement New feature or request p1-chore Doesn't change code behavior (priority)
Milestone

Comments

@bluwy
Copy link
Member

bluwy commented Apr 8, 2022

Clear and concise description of the problem

For Vite 3, we can review some experimental options to be stable APIs.

Suggested solution

Things to review:

Newer experimental options:

Alternative

No response

Additional context

Note:

For preview(), SvelteKit hasn't been using it as otherwise mentioned in the PR. They work differently that SvelteKit implements its own preview server.

Validations

@bluwy bluwy added the enhancement New feature or request label Apr 8, 2022
@bluwy bluwy added this to the 3.0 milestone Apr 8, 2022
@patak-dev
Copy link
Member

I think all the listed features under Things to review could be out of experimental. Maybe we could do individual PRs for each of them and add some projects from the ecosystem that are using them as reference?

css.devSourcemap we could delay the decision until have more users testing the feature, but leaning towards leaving it as experimental too.
optimizeDeps.extensions should probably stay as previously discussed

@bluwy
Copy link
Member Author

bluwy commented Apr 9, 2022

👍 Yeah I think things to review has been pretty stable too. I was thinking we can do one PR for all of them perhaps since it's a matter of removing the @experimental comment only. Will open a PR with some usage info soon.

@patak-dev patak-dev added the p1-chore Doesn't change code behavior (priority) label May 6, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request p1-chore Doesn't change code behavior (priority)
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants