Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(worker): bundle worker emit asset file #6599

Merged
merged 14 commits into from Mar 8, 2022
Merged

feat(worker): bundle worker emit asset file #6599

merged 14 commits into from Mar 8, 2022

Conversation

poyoho
Copy link
Member

@poyoho poyoho commented Jan 23, 2022 •
edited

Description

fix: #6594
fix: #5699
fix: #6706
fix: #7114

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Shinigami92
Shinigami92 reviewed Jan 23, 2022
View reviewed changes
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks okay to me

ygj6
ygj6 previously approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@ygj6 ygj6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

ygj6
ygj6 previously approved these changes Jan 25, 2022
View reviewed changes
@patak-dev patak-dev added the p2-nice-to-have Not breaking anything but nice to have (priority) label Jan 27, 2022
@patak-dev patak-dev added this to the 2.9 milestone Feb 10, 2022
@patak-dev
Copy link
Member

We discussed this PR @poyoho in the last team meeting and we can move forward with it. Thanks for keeping improving Vite's Worker story. Let's merge it during the 2.9 beta so we can get some extra testing.

patak-dev
patak-dev previously approved these changes Feb 12, 2022
View reviewed changes
@poyoho poyoho dismissed stale reviews from patak-dev and ygj6 via 581c178 March 3, 2022 14:18
@poyoho poyoho requested review from ygj6 and patak-dev March 5, 2022 00:19
@bluwy bluwy mentioned this pull request Mar 7, 2022
Closed
7 tasks
@patak-dev
Copy link
Member

@ygj6 would you help re-reviewing this PR if you have some time?

patak-dev
patak-dev reviewed Mar 8, 2022
View reviewed changes
packages/playground/worker/vite.config.ts Outdated
@@ -3,9 +3,10 @@ import { defineConfig } from 'vite'

export default defineConfig({
build: {
target: process.env.NODE_ENV === 'production' ? 'chrome60' : 'esnext'
// target: process.env.NODE_ENV === 'production' ? 'chrome60' : 'esnext'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change related to the esbuild issue @poyoho? Should we wait for it before merging this PR?

Copy link
Member Author

@poyoho poyoho Mar 8, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I open a issues in vite #7179

and open in esbuild too. evanw/esbuild#2089

I think not. I think chrome60 is not a important unit test.
The config may I copy from the issues repo in last time. 🙈

Copy link
Member

@patak-dev patak-dev Mar 8, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's uncomment this line if the change isn't needed then? Or remove the line directly?
We can merge it afterwards

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok.

@patak-dev patak-dev merged commit 0ade335 into vitejs:main Mar 8, 2022
@poyoho poyoho deleted the fix(worker)/bundle-worker-emit-asset-file branch March 8, 2022 10:24
@pd4d10 pd4d10 mentioned this pull request Apr 7, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@Shinigami92 Shinigami92 Awaiting requested review from Shinigami92

@ygj6 ygj6 Awaiting requested review from ygj6

Assignees
No one assigned
Labels
feat: web workers p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
Team Board
Archived in project
Release Plan
Status: Todo
Milestone
2.9
5 participants
@poyoho @patak-dev @Shinigami92 @ygj6 @Niputi