Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove virtual module prefix while generating manifest #6225

Merged
merged 2 commits into from Dec 22, 2021

Conversation

sibbng
Copy link
Contributor

@sibbng sibbng commented Dec 21, 2021

Description

Closes #6097
Closes #6208

Thanks to @khalwat for letting me know about the issue.
Related: #5601 (comment)

Related: ElMassimo/vite_ruby#156
Related: nystudio107/craft-vite#20

/cc @StefSchenkelaars @ElMassimo I didn't tested this with latest version of vite-ruby but you might need to revert your changes.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@ElMassimo
Copy link
Contributor

Vite Ruby does not rely on the presence of this char, so no changes are required once this is merged.

@khalwat
Copy link
Contributor

khalwat commented Dec 21, 2021

Thank you so much @sibbng !

@patak-dev patak-dev merged commit d51259b into vitejs:main Dec 22, 2021
@patak-dev patak-dev added the p5-urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority) label Dec 22, 2021
@patak-dev
Copy link
Member

Thanks for the fix @sibbng! Sorry for the regression, I didn't see how disruptive this problem was for the backend ecosystem until this PR. vite@2.7.6 includes this patch.
It would be good to improve our manifest tests and other parts related to your integrations. Please check our current CI tests and PRs for new cases so we avoid these problems in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p5-urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority) plugin: legacy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in @vitejs/plugin-legacy breaks manifest.json path to vite/legacy-polyfills
5 participants