Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ws types #6083

Merged
merged 4 commits into from Dec 12, 2021
Merged

fix: ws types #6083

merged 4 commits into from Dec 12, 2021

Conversation

Niputi
Copy link
Contributor

@Niputi Niputi commented Dec 12, 2021

Description

fix: #6073

had to change export type in ws.d.ts to get vite building.
have been confirmed by @bluwy to be working with svelte kit

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Niputi Niputi changed the title Fix/ws types fix: types Dec 12, 2021
@Niputi
Copy link
Contributor Author

Niputi commented Dec 12, 2021

failing test looks unrelated

@patak-dev
Copy link
Member

Re-running jobs

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for fixing this 👍🏼

@patak-dev
Copy link
Member

Using @bluwy as second approval here (as @Niputi commented, this has been testing by him in SvelteKit)
This also reverts the types to their prev state, so we have been using this already in the past

@patak-dev patak-dev changed the title fix: types fix: ws types Dec 12, 2021
@patak-dev patak-dev merged commit 1ded1a8 into vitejs:main Dec 12, 2021
@Niputi Niputi deleted the fix/ws-types branch December 12, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ws types incorrectly bundled
2 participants