Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ws types incorrectly bundled #6073

Closed
7 tasks done
benmccann opened this issue Dec 11, 2021 · 0 comments · Fixed by #6083
Closed
7 tasks done

ws types incorrectly bundled #6073

benmccann opened this issue Dec 11, 2021 · 0 comments · Fixed by #6083
Labels
dependencies Pull requests that update a dependency file p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority)

Comments

@benmccann
Copy link
Collaborator

benmccann commented Dec 11, 2021

Describe the bug

SvelteKit is unable to be updated due to an issue with ws types. I'm not sure if it's the cause, but #5340 bundled the ws types, and #5540 bumped the ws version but did not update https://github.com/vitejs/vite/blob/main/packages/vite/types/ws.d.ts

Reproduction

git clone git@github.com:sveltejs/kit.git

Update the Vite version in packages/kit/package.json to 2.7.1. Then run:

pnpm install
pnpm check

System Info

Vite 2.7.1

Used Package Manager

pnpm

Logs

packages/kit check$ tsc && svelte-check --ignore "src/packaging/test"
│ ../../node_modules/.pnpm/vite@2.7.1/node_modules/vite/dist/node/index.d.ts(50,54): error TS7016: Could not find a declaration file for module 'ws'. '/home/bmccann/src/kit/node_modules/.pnpm/ws@7.5.6/node_mod
│   Try `npm i --save-dev @types/ws` if it exists or add a new declaration (.d.ts) file containing `declare module 'ws';`
└─ Failed in 6.7s

Validations

@benmccann benmccann added bug p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) labels Dec 11, 2021
@Niputi Niputi added the dependencies Pull requests that update a dependency file label Dec 11, 2021
@Niputi Niputi mentioned this issue Dec 12, 2021
9 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Dec 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants