fix(html): empty script

[poyoho]

Description

fix: #6008

Additional context

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the Commit Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[patak-dev]

I don't know if this is the right fix, we should check why there isn't a string for that cached proxy. If an empty string is inserted in the cache (instead of undefined as I assume it is now), then we don't need to throw an error

[poyoho]

I don't know if this is the right fix, we should check why there isn't a string for that cached proxy. If an empty string is inserted in the cache (instead of undefined as I assume it is now), then we don't need to throw an error

@patak-dev thanks comment.

why there isn't a string for that cached proxy

so we need to find why isn't a string for that cached proxy case to fix? avoid using if to catch edge case.
I guess import "index.html?html-proxy&index=1.js" is used manually 😀.

[patak-dev]

I think the problem needs to be here

vite/packages/vite/src/node/plugins/html.ts

Line 231 in d4c5cff

const contents = node.children

[poyoho]

I think script children must be a TextNode, so the cache must be string.

[patak-dev]

You are right, the initial implementation was fine. Sorry for the noise, reverted it for you. Let's merge 👍🏼