fix(lexGlobPattern): edge case of glob import #6022
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
'/Tom\'s files/**'
, results in'/Tom\'
)
to get theendIndex
is fragile, the options code may contain annotation, e.g.get the wrong pos next to
type)<--
For 1, I tried to get the entire correct pattern string and pass it to
fast-glob
, it still returned an empty array of files (works failed), so just document it.For 2, fixed it.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).