Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lexGlobPattern): edge case of glob import #6022

Merged
merged 2 commits into from Dec 10, 2021
Merged

Conversation

ygj6
Copy link
Member

@ygj6 ygj6 commented Dec 9, 2021

Description

  1. when lexing the pattern, it may contain quote strings, e.g. '/Tom\'s files/**', results in '/Tom\'
  2. simply find index of ) to get the endIndex is fragile, the options code may contain annotation, e.g.
import.meta.globEager('/dir/*.json', {
    // (set type)
    assert: { type: 'raw' }
  })

get the wrong pos next to type)<--

For 1, I tried to get the entire correct pattern string and pass it to fast-glob, it still returned an empty array of files (works failed), so just document it.

For 2, fixed it.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@ygj6 ygj6 marked this pull request as draft December 9, 2021 07:59
@ygj6 ygj6 marked this pull request as ready for review December 9, 2021 08:33
@ygj6 ygj6 changed the title fix: edge case of lex glob pattern fix(lexGlobPattern): edge case of lexGlobPattern Dec 9, 2021
@ygj6 ygj6 changed the title fix(lexGlobPattern): edge case of lexGlobPattern fix(lexGlobPattern): edge case of glob import Dec 9, 2021
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'll be pretty rare for someone to put a comment inside the glob function, but it's nice to have nonetheless!

@patak-dev patak-dev merged commit d4c5cff into vitejs:main Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants