Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work when combined with vite_rails and vite_plugin_legacy #5832

Closed
7 tasks done
Eiryyy opened this issue Nov 25, 2021 · 2 comments
Closed
7 tasks done

Does not work when combined with vite_rails and vite_plugin_legacy #5832

Eiryyy opened this issue Nov 25, 2021 · 2 comments

Comments

@Eiryyy
Copy link

Eiryyy commented Nov 25, 2021

Describe the bug

This fix breaks the integration with Rails using vite_rails.

const polyfillId = '\0vite/legacy-polyfills'

Rails throws the following error and the legacy plugin does not work.

[ActionView::Template::Error] path name contains null byte

Reproduction

packages

  • rails (6.1.4.1)
  • vite_plugin_legacy (3.0.0)
  • vite_rails (3.0.0)

bin/vite build and start Rails in production mode

System Info

System:
    OS: macOS 12.0.1
    CPU: (8) arm64 Apple M1
    Memory: 64.34 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.5.0 - ~/.anyenv/envs/nodenv/versions/16.5.0/bin/node
    Yarn: 1.22.17 - ~/.anyenv/envs/nodenv/versions/16.5.0/bin/yarn
    npm: 7.19.1 - ~/.anyenv/envs/nodenv/versions/16.5.0/bin/npm
  Browsers:
    Chrome: 96.0.4664.55
    Firefox: 94.0.2
    Safari: 15.1
  npmPackages:
    @vitejs/plugin-legacy: ^1.6.3 => 1.6.3
    @vitejs/plugin-vue: ^1.10.0 => 1.10.0
    vite: ^2.6.10 => 2.6.10

Used Package Manager

npm

Logs

No response

Validations

@schelmo
Copy link
Contributor

schelmo commented Dec 5, 2021

same problem when using json_decode in php on the manifest

@Eiryyy
Copy link
Author

Eiryyy commented Jan 5, 2022

This issue has been resolved and is now closed.
ElMassimo/vite_ruby#156

@Eiryyy Eiryyy closed this as completed Jan 5, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants