Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): ?inline cannot self-accept #5433

Merged
merged 1 commit into from Oct 27, 2021

Conversation

aleclarson
Copy link
Member

When ?inline is used on a CSS import, the module produced is a simple export default of a string, so it should never self-accept HMR updates or else they go unhandled.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@aleclarson aleclarson added feat: hmr p4-important Violate documented behavior or significantly improves performance (priority) labels Oct 27, 2021
@patak-dev patak-dev merged commit d283d9b into vitejs:main Oct 27, 2021
@aleclarson aleclarson deleted the fix/hmr-inline-css branch February 25, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: hmr p4-important Violate documented behavior or significantly improves performance (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants