Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load-fallback catch #5412

Merged
merged 1 commit into from Oct 25, 2021
Merged

fix: load-fallback catch #5412

merged 1 commit into from Oct 25, 2021

Conversation

pd4d10
Copy link
Contributor

@pd4d10 pd4d10 commented Oct 25, 2021

Description

Added await to catch async errors correctly.

Additional context


What is the purpose of this pull request?

  • Bug fix

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was already done in #4703 by @iheyunfei, but we want to merge it during the 2.7 beta. Let's have this PR merged now so we can include it in today's 2.6 patch release

@patak-dev patak-dev merged commit e73281c into vitejs:main Oct 25, 2021
@pd4d10 pd4d10 deleted the patch-2 branch October 25, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants