Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): fix typo in overlay config hint #5343

Merged
merged 1 commit into from Oct 19, 2021
Merged

fix(client): fix typo in overlay config hint #5343

merged 1 commit into from Oct 19, 2021

Conversation

davidohlin
Copy link
Contributor

Description

I was trying to disable the overlay by setting hmr.overlay to false in the config as described in the overlay. However, the correct key is server.hmr.overlay. I also phrased it to look more like the description in the docs :-)

Additional context

No!


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev changed the title fix(client): fix typo in overlay fix(client): fix typo in overlay config hint Oct 19, 2021
@patak-dev patak-dev merged commit 96591bf into vitejs:main Oct 19, 2021
@davidohlin davidohlin deleted the fix-overlay-typo branch October 19, 2021 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants