Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use global location for import.meta.url rewrite (fix #5087) #5113

Merged
merged 2 commits into from Sep 28, 2021
Merged

fix: use global location for import.meta.url rewrite (fix #5087) #5113

merged 2 commits into from Sep 28, 2021

Conversation

cedeber
Copy link
Contributor

@cedeber cedeber commented Sep 27, 2021

Rewriting import.meta.urlwith window.location doesn't work in a Web Worker. So I replaced it by just location so that is uses the global var whether your are in the main thread or in a worker, which doesn't have access to window.

closes #5087

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added p3-minor-bug An edge case that only affects very specific usage (priority) feat: web workers labels Sep 28, 2021
@patak-dev patak-dev merged commit 0b54853 into vitejs:main Sep 28, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
@cedeber @aleclarson
fix: use global location for import.meta.url rewrite (fix vitejs#5087) (
adcbd9c 
vitejs#5113)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukastaegert lukastaegert lukastaegert left review comments

@patak-dev patak-dev patak-dev approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees
No one assigned
Labels
feat: web workers p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

import.meta.url rewrite doesn't work in web worker
4 participants
@cedeber @patak-dev @Shinigami92 @lukastaegert