Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): missing return type on logError #5067

Merged
merged 1 commit into from Sep 24, 2021
Merged

fix(types): missing return type on logError #5067

merged 1 commit into from Sep 24, 2021

Conversation

yingpengsha
Copy link
Contributor

Description

image
image

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added the p1-chore Doesn't change code behavior (priority) label Sep 24, 2021
@antfu antfu changed the title types: missing return type on logError fix(types): missing return type on logError Sep 24, 2021
@antfu antfu merged commit 3c9f1a1 into vitejs:main Sep 24, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
@yingpengsha @aleclarson
fix(types): missing return type on logError (vitejs#5067)
cd3a064
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees
No one assigned
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yingpengsha @patak-dev @Shinigami92 @antfu