Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: specify full filepath to importMeta.d.ts, fix #4125 #4138

Merged
merged 1 commit into from Jul 6, 2021

Conversation

IanVS
Copy link
Contributor

@IanVS IanVS commented Jul 5, 2021

Description

Fixes #4125

The docs don't specify that a full filepath with extension is required, but it does seem to be.

Additional context

These triple-slash directives seem to be pretty fiddly. There has been #4031 and #4003 trying to get this working.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • [] Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev
Copy link
Member

Thanks @jceipek and @IanVS!
@gunters63, @userquin would you confirm that this PR fixes your issues?

@patak-dev patak-dev added the p3-minor-bug An edge case that only affects very specific usage (priority) label Jul 6, 2021
@gunters63
Copy link

Thanks @jceipek and @IanVS!
@gunters63, @userquin would you confirm that this PR fixes your issues?

Yes, works for me. Thanks!

@patak-dev patak-dev changed the title fix: specify full filepath to importMeta.d.ts (fixes #4125) fix: specify full filepath to importMeta.d.ts, fix #4125 Jul 6, 2021
@patak-dev patak-dev merged commit 3bc1d78 into vitejs:main Jul 6, 2021
@IanVS IanVS deleted the 4125-typescript-import-path branch July 6, 2021 15:05
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting typescript errors (unsafe member access on import.meta.env) since update to 2.4.0
4 participants