Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the current main branch code build the vite project error #4059

Merged
merged 2 commits into from Jul 2, 2021

Conversation

ygj6
Copy link
Member

@ygj6 ygj6 commented Jul 1, 2021

Description

The current main branch code build the vite project error:
微信截图_20210701115343

The reason is caused by estree-walker@3.0.0issue.
I think we should fall reverse to estree-walker@2.0.2,wait for the problem to be resolved before upgrading

Related commit:334ba1d

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sodatea
Copy link
Member

sodatea commented Jul 1, 2021

What project? Could you please open an issue with regard to the specific error?

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also experiencing this issue when running yarn dev in playgrounds, I think it is safer to rollback to 2.0.2.

@patak-dev patak-dev requested a review from antfu July 1, 2021 21:27
@antfu antfu merged commit 4adc970 into vitejs:main Jul 2, 2021
sodatea added a commit to sodatea/vite that referenced this pull request Jul 9, 2021
`tsc` does not support custom file extensions, which is used for the
emitted client files.

It does not understand the `exports` field of other packages,
making it impossible to use pure-ESM dependencies (vitejs#4059),
sodatea added a commit to sodatea/vite that referenced this pull request Jul 9, 2021
`tsc` does not support custom file extensions, which is used for the
emitted client files.

It does not understand the `exports` field of other packages,
making it impossible to use pure-ESM dependencies (vitejs#4059),
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants