Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid importing in source that __vitePreload has declared (close #4016) #4041

Merged
merged 2 commits into from Jul 1, 2021

Conversation

xingxiuyi
Copy link
Contributor

@xingxiuyi xingxiuyi commented Jun 30, 2021

fix: Avoid importing in source that __vitePreload has declared (close #4016)

Description

this pull request fix #4016 (Error: Identifier '__vitePreload' has already been declared)

Additional context

If the Identifier '__vitePreload' has already been declared, there is no need to repeat the import

Use this simple project to verify: https://github.com/xingxiuyi/test-vite-async-import


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Co-authored-by: patak <matias.capeletto@gmail.com>
@antfu antfu merged commit bd34203 into vitejs:main Jul 1, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vite build error: Identifier '__vitePreload' has already been declared
3 participants