Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builtin-modules doesn't include fs/promises causing vite failing to recognize builtin module #4037

Closed
6 tasks done
raythurnevoid opened this issue Jun 30, 2021 · 3 comments
Closed
6 tasks done
Labels
bug: upstream Bug in a dependency of Vite feat: ssr

Comments

@raythurnevoid
Copy link
Contributor

raythurnevoid commented Jun 30, 2021

Describe the bug

fs/promises isn't included in the array given by builtin-modules package but it is in import { builtinModules } from 'module';:

image

This cause Vite to give this error:

Failed to resolve import "fs/promises" from "src\routes\api\get-file-content.ts". Does the file exist?
Error: Failed to resolve import "fs/promises" from "src\routes\api\get-file-content.ts". Does the file exist?
    at formatError (C:\workspace\m7d\vite\packages\vite\dist\node\server\pluginContainer.js:173:46)
    at TransformContext.error (C:\workspace\m7d\vite\packages\vite\dist\node\server\pluginContainer.js:169:19)
    at normalizeUrl (C:\workspace\m7d\vite\packages\vite\dist\node\plugins\importAnalysis.js:126:26)
    at async TransformContext.transform (C:\workspace\m7d\vite\packages\vite\dist\node\plugins\importAnalysis.js:259:57)
    at async Object.transform (C:\workspace\m7d\vite\packages\vite\dist\node\server\pluginContainer.js:374:30)
    at async Object.transformRequest (C:\workspace\m7d\vite\packages\vite\dist\node\server\transformRequest.js:122:29)
    at async instantiateModule (C:\workspace\m7d\vite\packages\vite\dist\node\ssr\ssrModuleLoader.js:44:10)

Reproduction

Use import "fs/promises".

I'll provide a repo in the next days.

System Info

System:
    OS: Windows 10 10.0.19042
    CPU: (16) x64 AMD Ryzen 9 4900H with Radeon Graphics
    Memory: 17.22 GB / 31.42 GB
  Binaries:
    Node: 16.2.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.10 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 7.13.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.19041.1023.0), Chromium (91.0.864.59)
    Internet Explorer: 11.0.19041.1

Used Package Manager

npm

Logs

Failed to resolve import "fs/promises" from "src\routes\api\get-file-content.ts". Does the file exist?
Error: Failed to resolve import "fs/promises" from "src\routes\api\get-file-content.ts". Does the file exist?
    at formatError (C:\workspace\m7d\vite\packages\vite\dist\node\server\pluginContainer.js:173:46)
    at normalizeUrl (C:\workspace\m7d\vite\packages\vite\dist\node\plugins\importAnalysis.js:126:26)
    at async TransformContext.transform (C:\workspace\m7d\vite\packages\vite\dist\node\plugins\importAnalysis.js:259:57)
    at async Object.transform (C:\workspace\m7d\vite\packages\vite\dist\node\server\pluginContainer.js:374:30)
    at async Object.transformRequest (C:\workspace\m7d\vite\packages\vite\dist\node\server\transformRequest.js:122:29)
    at async instantiateModule (C:\workspace\m7d\vite\packages\vite\dist\node\ssr\ssrModuleLoader.js:44:10)

Validations

@chuanqisun
Copy link

My temporary workaround is to specify fs/promises as external in the rollup options:

// vite.config.js
import { defineConfig } from "vite";

export default defineConfig({
  build: {
    rollupOptions: {
      external: ["fs/promises"],
    },
  },
});

@sodatea sodatea added bug bug: upstream Bug in a dependency of Vite feat: ssr and removed pending triage labels Aug 23, 2021
@drschwabe
Copy link

chaunqisun's workaround doesn't seem to work with current SvelteKit ie- adding that config to svelte.config.js > kit > vite
still cannot import fs/promises without Svite throwing JSON error

@sveltejs/kit 1.0.0-next.1
svelte 3.42.6

@patak-dev
Copy link
Member

Closed by #5248

@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug: upstream Bug in a dependency of Vite feat: ssr
Projects
None yet
Development

No branches or pull requests

5 participants