fix: ensure that esbuild uses the same working directory as Vite #4001
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are a few places where the assumption is made that Vite and esbuild have the same working directory, for example here:
vite/packages/vite/src/node/optimizer/index.ts
Line 284 in f3643d8
This leads to unexpected behaviour when the process invoking Vite has called
process.chdir()
, as that assumption is no longer valid. This can lead toneedsInterop()
returningtrue
incorrectly, as exhibited in the example of #4000 (comment).What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).