Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): add dot-all flag to match all characters, fix #3761 #3780

Merged
merged 1 commit into from Jul 7, 2021

Conversation

Sociosarbis
Copy link
Contributor

Description

fix #3761

Additional context

We can make a assumption that every url pass to clearUrl is valid. As long as url is valid, we don't care about what character appears in query or hash.This is how node does in URL module. So here we can simply add dot-all flag to match all characters after the question mark and also the number sign.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev added the p3-minor-bug An edge case that only affects very specific usage (priority) label Jul 7, 2021
@patak-dev patak-dev changed the title fix(utils): #3761 add dot-all flag to match all characters fix(utils): add dot-all flag to match all characters, fix #3761 Jul 7, 2021
@patak-dev patak-dev merged commit b9cdfbe into vitejs:main Jul 7, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL Query Parameter with %0A causes vite to fail
3 participants